909484 - Don't list the same app multiple times in the collection

Status: RESOLVED FIXED

(Marketplace Graveyard :: Admin Tools, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot.png

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/curation/collection/55
2. Click on Add App to Collection
3. Search for Desk.com
4. Click on the app to add it to the collection
5. Repeat steps 2-4 multiple times

expected behavior:
We don't list the same app multiple times.

observed behavior:
Looks like the API returns the right status (400) with the response: [12:56:54.472] "[req] Response data: " "{"detail": "`app` already exists in collection."}"

However, the app gets listed multiple times. See screenshot. Note that the app doesn't get saved multiple times

Comment 1

[krupa raj[:krupa]]

[13:04:40.120] TypeError: l.remove is not a function @ https://marketplace-dev-cdn.allizom.org/media/rocketfuel/js/include.js?b=b66210f-521b79e3:5

Comment 2

[Matt Basta [:basta]]

https://github.com/mozilla/rocketfuel/commit/a9144a64b6906068ef01b0c7627c4c90d5a141a8

krupa stahp filing bugs for things i haven't finished building yet

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Basta, you don't have bugs on file to implement this. So Krupa files the bugs. That seems reasonable, yeah?