909597 - Make jsdebugapi.h not depend on jsapi.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

One sub-goal of the "minimize-jsapi" work is that no exported JS headers should include jsapi.h.  jsdbgapi.h is one such header, and it's easy to remedy.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Make jsdbgapi.h not depend on jsapi.h.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Rename jsdbgapi.{h,cpp} as {js,vm}OldDebugAPI.{h,cpp}.

This was Luke's suggestion.  I'm not entirely convinced by it...
js/OldDebugAPI.h is still used in quite a few places, more than the "Old" part
of the name suggests.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 795776 [details] [diff] [review]
(part 2) - Rename jsdbgapi.{h,cpp} as {js,vm}OldDebugAPI.{h,cpp}.

jimb, what do you think about this renaming?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 795776 [details] [diff] [review]
(part 2) - Rename jsdbgapi.{h,cpp} as {js,vm}OldDebugAPI.{h,cpp}.

Review of attachment 795776 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/src/nsScriptSecurityManager.cpp
@@ +10,3 @@
>  #include "xpcprivate.h"
>  #include "XPCWrapper.h"
>  #include "nsScriptSecurityManager.h"

Please don't put anything new above the main header. It's not good now, but there's no need to make it worse.

::: content/xbl/src/nsXBLSerialize.cpp
@@ +7,1 @@
>  #include "nsXBLSerialize.h"

Same here

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8fed1171d6a
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a3ed74a0c95

Comment 6

[Nicholas Nethercote [inactive]]

Comment on attachment 795776 [details] [diff] [review]
(part 2) - Rename jsdbgapi.{h,cpp} as {js,vm}OldDebugAPI.{h,cpp}.

FWIW, here's Luke's rationale (from a private email conversation) for the name change:

"OldDebugAPI.h was, I think, the pre-jsfriendapi.h JS_FRIEND_API dumping ground.  I think the Old prefix is good here, though: nobody should be adding new uses, we should be removing old uses, and the few stragglers that remain after jsd is 
removed will get redistributed."

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e8fed1171d6a
https://hg.mozilla.org/mozilla-central/rev/2a3ed74a0c95