909631 - Renable Everything me test (fails in ci)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[James Lal [:lightsofapollo]]

https://travis-ci.org/mozilla-b2g/gaia/builds/10650421#L210

Comment 2

[Cristian Rodriguez (:crdlc)]

Please Evyatar, could you take a look to this bug?, it is failing after landing the migration feature

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

It fails on the "asyncStorage" object, even though it's included in the homescreen's index.html. it works well when building - any idea what the test does differently?

including async_storage: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/index.html#L18
including everything.me.js: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/index.html#L38
the JS line: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/everything.me.js#L196

Comment 4

[Cristian Rodriguez (:crdlc)]

Yep, but it is not included on test file

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/test/unit/everything.me_test.js

For example you can take a look to contacts how the asyncStorage is a mock for testing

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/test/unit/link_test.js

Comment 5

[Evyatar 'Tron' Amitay (everything.me)]

so I should copy the mock_asyncStorage into the homescreen's test folder, and include it in everything.me's test JS?

just noting - this means that the "keys" will always be empty so this function won't "really" run. can I add demo values in my mock file?

Comment 6

[Cristian Rodriguez (:crdlc)]

Yes, you can add to your mock what you want and test it. If it is empty, really the function doesn't run and test shouldn't fail neither. Although if you add some key you can test the behavior of your algorithm as well. Thanks

Comment 7

[Evyatar 'Tron' Amitay (everything.me)]

should I mock the "localStorage" as well? or is that built in?

Comment 8

[Cristian Rodriguez (:crdlc)]

The mock could be like this, forget localStorage, right? or do you need to mock localStorage for something?

https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/test/unit/mock_asyncstorage.js

Comment 9

[Evyatar 'Tron' Amitay (everything.me)]

if I just create this it would work - but it won't do anything.
I want to force some stuff into the localStorage, but the method to actually run.

Comment 10

[Cristian Rodriguez (:crdlc)]

At the beginning of the test you can add

MockasyncStorage.keys = {
 'blabla' : 'aaaa',
 'blabla' : 'bbbb'
};

At the end reset if by default

MockasyncStorage.keys = {};

So you have a storage filled :)

Comment 11

[Evyatar 'Tron' Amitay (everything.me)]

but I want to add the keys to the localStorage, not the async one :)

could I add inside the "suiteSetup" method something like that
localStorage["MY KEY"] = "MY VALUE";

or is that not the correct way?

Comment 12

[Cristian Rodriguez (:crdlc)]

yes, you can BUT remember save the original localStorage in the suiteSetup and restore this one in the suiteTeardown

For example mocking elementFromPoint from DOM

suite('blabla.js >', function() {

 var realElementFromPoint;

 suiteSetup(function() {
   realElementFromPoint = HTMLDocument.prototype.elementFromPoint;
 });

 suiteTeardown(function() {
   HTMLDocument.prototype.elementFromPoint = realElementFromPoint;
 });

 test('My test ', function() {
   HTMLDocument.prototype.elementFromPoint = function() {
     return {x: 0, y: 0};
   };
   // Do something
 });
}

Comment 13

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 14

[Cristian Rodriguez (:crdlc)]

Comment on attachment 795969 [details]
Patch - redirect to github PR

Great work as usual! thanks

Comment 15

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/babd62446049592fb912aec0025c33a871979761

Comment 16

[Evyatar 'Tron' Amitay (everything.me)]

adding leo since the original ticket 907160 also has leo+

Comment 18

[Julien Wajsberg [:julienw]]

If this doesn't fix a real bug, I don't think we want to include this in 1.1. Unit tests are (unfortunately) not passing in 1.1 for a long time anyway.

Comment 19

[Andrew Overholt [:overholt]]

We discussed this during triage today and the consensus was that it didn't meet the criteria for what should block 1.1:

  https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block

Obviously if you disagree please renom with some comments :)