909693 - B2G RIL: JavaScript Error: "Error: Don't know about this message type: undefined" {file: "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line: 1159}

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

Attachment: logcat.txt

At REQUEST_QUERY_NETWORK_SELECTION_MODE parcel handler[1], when we see an error, it reports back to RadioInterface but with no rilMessageType/rilMessageToken defined.

The request was triggered by |getNetworkSelectionMode()|[2], which is only called in |requestNetworkInfo()|[3].

[1]: http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#5358
[2]: http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#1063
[3]: http://mxr.mozilla.org/mozilla-central/source/dom/system/gonk/ril_worker.js#1035

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Cause no harm and is easy to fix.  Just skip error messages as other grouped requests do for now.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b2a037b3e9e9

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b2a037b3e9e9