909700 - DuckDuckGo Plus gives strange error message after installation on a clean profile

Status: RESOLVED INVALID

(Firefox :: Extension Compatibility, defect)

Description

[Manuela Muntean [Away]]

Attachment: screenshot.PNG

Reproducible with the latest Beta - Firefox 24 beta 6 - build ID: 20130826142034
Reproducible with the latest Nightly - build ID: 20130826190748
Reproducible with the latest Aurora - build ID: 20130826004002
Not reproducible with the latest Release - Firefox 23.0.1

Steps to reproduce:

1. Open Firefox and install DuckDuckGo Plus add-on from https://addons.mozilla.org/en-US/firefox/search-tools/
 
Expected results: the add-on should install without any issues or error messages

Actual results: after installation, the message shown in the screenshot appears

Notes: 

1. I've also tried to install: InstantFox 2.8.3, StumbleUpon 4.16 and Add Google Search To New Tab PAge 1.0.2, and none of them reproduce this issue.
2. All 4 searches (Search bar, about:home, contextual menu option, URL bar) work as expected (using DuckDuckGo Plus).

Comment 1

[Tracy Walker [:tracy]]

confirmed this is a regression.  

The error message doesn't appear to have affected the add-on installation.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

The developers have been informed about this bug.

Comment 3

[Manuela Muntean [Away]]

Regression range below:

Last good nightly: 2013-08-14
First bad nightly: 2013-08-15

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-08-14&enddate=2013-08-15

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

I suppose that this is caused by bug 493051, and the add-on is jut not checking for the existence of the search engine before attempting to install it again.

Comment 5

[marek]

Well, we are using a library which should already do that (https://github.com/mozilla/example-search-addon/). Is that the wrong approach? Should we check for that ourselves? 

Also, do you think we should be using this library? We've been asked to do so by Kris Maglione in one review but we've been having issues with it.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

Kris, does the library account for the change in bug bug 493051?

Comment 7

[marek]

Any news on this?

I've already created an issue on GitHub for it (https://github.com/mozilla/example-search-addon/issues/2), should I try to implement this behaviour? What would you suggest?

Thanks

Comment 8

[Kris Maglione [:kmag]]

I'll try to look into it this week.

Comment 9

[marek]

Kris: this should no longer be happening on the DuckDuckGo Plus addon.

I am not sure about the example-search-addon though.

Comment 10

[Andy McKay]

This is about a legacy extension which is no longer valid in Firefox Quantum, closing.