909712 - [Partners] Yahoo! Partner repack changes for Firefox 25

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect, P2)

Description

[Sunil]

Attachment: repack_config_changes_for_FF24_Yahoo.diff

Requesting to provide FF24 beta builds for the attached diff file.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 795967 [details] [diff] [review]
repack_config_changes_for_FF24_Yahoo.diff

Review of attachment 795967 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but it includes a bunch of binary file changes. Can you try recreating the diff with "hg diff --git", which should provide a patch that I'll be able to apply?

Comment 2

[Mike Kaply [:mkaply]]

After conversations with Ben, we decided I would just go ahead and push:

https://hg.mozilla.org/build/partner-repacks/rev/0b4d6148580d

Comment 3

[Mike Kaply [:mkaply]]

Sorry, wrong bug.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #1)
> Comment on attachment 795967 [details] [diff] [review]
> repack_config_changes_for_FF24_Yahoo.diff
> 
> Review of attachment 795967 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks fine, but it includes a bunch of binary file changes. Can you try
> recreating the diff with "hg diff --git", which should provide a patch that
> I'll be able to apply?

Comment 5

[Sunil]

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> (In reply to Ben Hearsum [:bhearsum] from comment #1)
> > Comment on attachment 795967 [details] [diff] [review]
> > repack_config_changes_for_FF24_Yahoo.diff
> > 
> > Review of attachment 795967 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > This looks fine, but it includes a bunch of binary file changes. Can you try
> > recreating the diff with "hg diff --git", which should provide a patch that
> > I'll be able to apply?

Hi Ben,

  Please find the recreated diff with "hg diff --git".

Comment 6

[Sunil]

Attachment: repack_config_changes_for_FF24_Yahoo.diff

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 802042 [details] [diff] [review]
repack_config_changes_for_FF24_Yahoo.diff

Review of attachment 802042 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to my eyes. I've landed this patch so these changes will get included for the Firefox 24.0 builds.

Comment 8

[Sunil]

Can you please submit the FF24 patch to head as we have released FF24. On head checkout from mercury server we still get FF23 Configs.
To expedite the FF25 release, here are the FF25 config patch(attached with the bug)

Comment 9

[Sunil]

Attachment: repack_config_changes_for_FF25_Yahoo.diff

Comment 10

[Chris Cooper [:coop] (he/him)]

(In reply to Sunil from comment #8)
> Can you please submit the FF24 patch to head as we have released FF24. On
> head checkout from mercury server we still get FF23 Configs.
> To expedite the FF25 release, here are the FF25 config patch(attached with
> the bug)

Did you run |hg update| after pulling? 

Ben landed the changes for Firefox 24 on September 10: https://hg.mozilla.org/build/partner-repacks/rev/d3f7cc145b5d

Comment 11

[Sunil]

Thanks Chris for the update, We get the latest configs. 
Please use this ticket to provide FF25 builds

Comment 12

[Chris Cooper [:coop] (he/him)]

Comment on attachment 817090 [details] [diff] [review]
repack_config_changes_for_FF25_Yahoo.diff

Review of attachment 817090 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/partner-repacks/rev/14d78845b27f

Comment 13

[Chris Cooper [:coop] (he/him)]

Generating new builds with the updated config now.

Comment 14

[Chris Cooper [:coop] (he/him)]

Sunil, builds are available in the canonical place now:

https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/25.0-candidates/build3/partner-repacks/

Comment 15

[Sunil]

Thanks Chris