Slide Down/Up transitions broken

RESOLVED INCOMPLETE

Status

defect
RESOLVED INCOMPLETE
6 years ago
2 years ago

People

(Reporter: mjschranz, Assigned: dimkov2012, Mentored)

Tracking

Details

(Whiteboard: [good first bug])

(Reporter)

Description

6 years ago
They transition properly on the "end" events of trackevents but their start isn't triggering properly and instead just appears.
(Reporter)

Updated

6 years ago
Assignee: schranz.m → nobody
(Reporter)

Updated

6 years ago
Assignee: nobody → dimkov2012
Whiteboard: mentor=mjschranz
Are there certain cases where it doesn't work? I just added a text event, and transitioned it with slide up, worked on both start and end.

Maybe it was fixed already in another patch/refactor?
Flags: needinfo?(schranz.m)
(Reporter)

Updated

6 years ago
Flags: needinfo?(schranz.m)
Whiteboard: mentor=mjschranz
(Reporter)

Comment 2

6 years ago
The problem is limited to Chrome.

Comment 3

6 years ago
It is limited Chrome and Opera.
Whiteboard: [mentor=thecount][mentor=mjschranz]
(Reporter)

Updated

6 years ago
Whiteboard: [mentor=thecount][mentor=mjschranz] → [mentor=thecount][mentor=mjschranz][good first bug]

Comment 4

6 years ago
Okay, I ran a good amount of testing (basically what I've been doing last few weeks) and... I don't know. I can say 100% - this is not webkit's problem, Chrome can do these types of operations. I ran a quick test to prove it:
https://reventl.makes.org/thimble/slide-test-1
This page has same css structure as the popcorn page and it works okay. I think it might be something outside of css, maybe in the playing mechanics? Somewhere around popcorn.text.js maybe?
Also, since Fade has the same problem (no start only finish) it's definitely not a movement/margin problem. It can't evoke the starting effect for some reason...
Matt, Dima, we should move this forward...
Maybe this might have to do with the transition off event firing before the transition is done, thus we hide it too soon?

I can take a closer look.
Flags: needinfo?(scott)
Looks like it is due to this: https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/templates/assets/plugins/text/popcorn.text.js#L307-L310

More info lives here: http://webmademovies.lighthouseapp.com/projects/65733/tickets/3066

I'm not too familiar with what was going on then yet, but everything looks to be fine now without it. It actually seems now the hack prevents it from transitioning.

Looks like Humph and Cade were the ones involved in the initial ticket, so would love some input from either of them.

I say confirm if we still need the hack, if not, we should nuke it.
Flags: needinfo?(scott)
Flags: needinfo?(david.humphrey)
Flags: needinfo?(cade)
(Reporter)

Comment 8

5 years ago
Supporting Safari is becoming more and more like a no go it seems....
I can't confirm if Safari fixed that issue - does removing it solve the problems in Chrome/Opera? (sounds like blink has issues with the hack?)
Flags: needinfo?(cade)
Removing it does solve the issue in chrome, and same, I cannot confirm with Safari. Might be fine there too.
I'm not clear what you need from me here, removing NEEDINFO.
Flags: needinfo?(david.humphrey)
Mentor: scott schranz.m
Mentor: schranz.m, scott
Whiteboard: [mentor=thecount][mentor=mjschranz][good first bug] → [good first bug]
Mentor: schranz.m, scott
Popcorn Maker is no longer under active development.

https://learning.mozilla.org/blog/product-update-for-appmaker-and-popcorn-maker
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.