Closed Bug 909757 Opened 8 years ago Closed 8 years ago

"warning: empty character constant" in builtin/String.js

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
> In file included from selfhosted.msg.h:15:
> ./../builtin/String.js:30:13: warning: empty character constant [-Winvalid-pp-token]
>     var T = '';
>             ^
> 1 warning generated.

This warning is a weird consequence of using the C preprocessor on JS code.

I just realized it's fixable.
Attachment #796023 - Attachment description: bug-cpp-warning-v1.patch → v1
Attachment #796023 - Flags: review?(till)
Comment on attachment 796023 [details] [diff] [review]
v1

Review of attachment 796023 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to fix that for ages now, thank you!

Ideally, we'd disable this warning, as there's nothing wrong with the code at all, but I'm entirely fine with doing this for now.
Attachment #796023 - Flags: review?(till) → review+
Comment on attachment 796023 [details] [diff] [review]
v1

Review of attachment 796023 [details] [diff] [review]:
-----------------------------------------------------------------

yay
https://hg.mozilla.org/mozilla-central/rev/b37239067bff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Assignee: general → jorendorff
You need to log in before you can comment on or make changes to this bug.