909757 - "warning: empty character constant" in builtin/String.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Attachment: v1

> In file included from selfhosted.msg.h:15:
> ./../builtin/String.js:30:13: warning: empty character constant [-Winvalid-pp-token]
>     var T = '';
>             ^
> 1 warning generated.

This warning is a weird consequence of using the C preprocessor on JS code.

I just realized it's fixable.

Comment 1

[Till Schneidereit [:till]]

Comment on attachment 796023 [details] [diff] [review]
v1

Review of attachment 796023 [details] [diff] [review]:
-----------------------------------------------------------------

I've been meaning to fix that for ages now, thank you!

Ideally, we'd disable this warning, as there's nothing wrong with the code at all, but I'm entirely fine with doing this for now.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 796023 [details] [diff] [review]
v1

Review of attachment 796023 [details] [diff] [review]:
-----------------------------------------------------------------

yay

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b37239067bff