909765 - Make TextureClient and CompositableClient ref counting thread-safe

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

With async video stuff this should have been made thread-safe, my bad.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Thread-safe ref counting for TextureClient and CompositableClient

Comment 2

[Sotaro Ikeda [:sotaro]]

Comment on attachment 796041 [details] [diff] [review]
Thread-safe ref counting for TextureClient and CompositableClient

Good catch! Looks good to me.

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6006fb455fd

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 796041 [details] [diff] [review]
Thread-safe ref counting for TextureClient and CompositableClient

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 858914
User impact if declined: thread-unsafe code, could lead to rare instability.
Testing completed (on m-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): very low risk
String or IDL/UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6006fb455fd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c258a05097e0

Comment 7

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.