909770 - Make Fixed text plugin positions occupying entire container

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Matthew Schranz [:mjschranz]]

It's minor, but to make fixed positions work well ideally they shouldn't occupy the entire container.

The correct solution will most likely involve some JS trickery to mimic the current work being done entirely with CSS.

Comment 1

[Scott [:thecount] Downe]

Yeah, I'm thinking this too.

We should just make fixed positions be pre set custom positions.

Comment 2

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/182

Ended up being easier than I thought.

If I knew it was as easy as it was, I would of requested it be done in bug 905634 as it pretty much refactors the way we handle fixed positions, and thus no longer needs the changes in bug 905634.

I did have to change 20px padding into a percentage, which, is never going to work. 20px padding is a broken number, as it'll never be the same if medai queries resize everything.

I picked 3% as it closest resembles the previous 20px in a common screen size, my screen size :P

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 796132 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/182

Found a bug while stagging :D

If you set position to fixed, and try to drag it, it goes into a weird resize state.

It is caused because my fixed position used right, instead of width, which causes jquery ui drag n drop to have fits.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 796132 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/182

Questions.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 796132 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/182

Fixed one, answered the other. Let me know if the answer is enough.

Comment 6

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/5c6ec6a5dda9ccc9dad7e972116abeb67a4b3eb6

Needs verification.

Comment 7

[Matthew Schranz [:mjschranz]]

On production.