909819 - Fix assertions in 509719-2 crashtests caused by repeated/recursive loadOverlay calls

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[:Gijs (he/him)]

(In reply to Neil Deakin from bug 509719 comment 16)
> What's happening here is that:
> 
> - The main document loads and calls loadOverlay, starting an overlay load
> - The main document finishes loading and calls ResolveForwardReferences
> which sets mResolutionPhase to 'done'
> - The overlay loads, calls LoadOverlay again and tries to add it but fails
> because mResolutionPhase is set to 'done'
> 
> I don't know what this code should be doing though. It seems however that
> resolving references shouldn't be done until, or should be done again when
> the overlays have loaded.

So, this. But also, see bug 330458. In fact, I'm fairly sure fixing that issue would fix this issue. Judging by bug 330458 comment 49, this isn't trivial.

Comment 1

[Andrew McCreight [:mccr8]]

XUL overlays were removed in bug 1426763.