909826 - OdinMonkey: unify GenerateEntry

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

The ARM and x86/x64 GenerateEntry functions are basically the same.  (Along the same lines it'd be nice to unify the FFI paths too but that is for a future patch.)

Comment 1

[Luke Wagner [:luke]]

Attachment: step 1

This patch changes the x86/x64 entry to take a 'globalData' argument, like ARM does.

Comment 2

[Luke Wagner [:luke]]

Attachment: step 2

Unify them.  I'm pretty sure StackDecrementForCall is doing the same calculation but I'd certainly appreciate a double check.

Comment 3

[Luke Wagner [:luke]]

Attachment: tidy-stack-overflow-exit

While I was in the area...

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 796115 [details] [diff] [review]
step 1

Review of attachment 796115 [details] [diff] [review]:
-----------------------------------------------------------------

Cool to finally see this getting factored out!

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 796116 [details] [diff] [review]
step 2

Actually, Marty wrote these, so I should give him the reviews.

Comment 6

[Marty Rosenberg [:mjrosenb]]

Comment on attachment 796116 [details] [diff] [review]
step 2

Review of attachment 796116 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/AsmJS.cpp
@@ +5256,5 @@
>  #endif
>  
> +    // ARM and x64 have a globally-pinned HeapReg (x86 uses immediates in
> +    // effective addresses).
> +#if defined(JS_CPU_X64) or defined(JS_CPU_ARM)

I am not a huge fan of c++'s English replacements for C operators.

Comment 7

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2741f512f37b
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d96288e8621
https://hg.mozilla.org/integration/mozilla-inbound/rev/6de29dc70874

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2741f512f37b
https://hg.mozilla.org/mozilla-central/rev/0d96288e8621
https://hg.mozilla.org/mozilla-central/rev/6de29dc70874