909853 - ContentDispatchChooser isn't showing anything on links it can't open

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Attachment: Patch

The multi-locale repacks broke the content dispatch chooser toasts that say "Couldn't find an application to open this link". Fix it!

I also added a logging string when these fail so that its a bit easier to diagnose these reports.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 796141 [details] [diff] [review]
Patch

Thankfully, this doesn't need real string changes and we can uplift it!

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 796141 [details] [diff] [review]
Patch

>diff --git a/mobile/android/components/ContentDispatchChooser.js b/mobile/android/components/ContentDispatchChooser.js

>+        Services.console.logStringMessage("Can't open uri " + aURI.spec);

We should not add this since it shows a URL and breaks privacy

>diff --git a/mobile/android/locales/jar.mn b/mobile/android/locales/jar.mn

>   locale/@AB_CD@/browser/payments.properties      (%chrome/payments.properties)
>+  locale/@AB_CD@/browser/handling.properties    (%chrome/handling.properties)

align better

r+ but we really need to remove the log

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/7fd6c2e59b65

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 796141 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 792077
User impact if declined: Nothing shown when the user clicks some links
Testing completed (on m-c, etc.): Landed on mc today.
Risk to taking this patch (and alternatives if risky): Low risk. Overwrites some strings, but we've been shipping this localization file for awhile, just not using it. AFAIK, localizers have localized it, but its just never shown to people.
String or IDL/UUID changes made by this patch: This fixes up some configuration files to bundle things correctly. i.e. we're shipping the same strings as always, we're just using the right ones now.

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 796141 [details] [diff] [review]
Patch

Although a nice to have, as long as we are functionally correct I do not want to rush this in our final beta's so approving on aurora only at this time.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7fd6c2e59b65

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c403d63667fe