Closed Bug 909853 Opened 6 years ago Closed 6 years ago

ContentDispatchChooser isn't showing anything on links it can't open

Categories

(Firefox for Android :: General, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26
Tracking Status
firefox24 --- wontfix
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: wesj, Assigned: wesj)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
The multi-locale repacks broke the content dispatch chooser toasts that say "Couldn't find an application to open this link". Fix it!

I also added a logging string when these fail so that its a bit easier to diagnose these reports.
Comment on attachment 796141 [details] [diff] [review]
Patch

Thankfully, this doesn't need real string changes and we can uplift it!
Attachment #796141 - Flags: review?(mark.finkle)
Comment on attachment 796141 [details] [diff] [review]
Patch

>diff --git a/mobile/android/components/ContentDispatchChooser.js b/mobile/android/components/ContentDispatchChooser.js

>+        Services.console.logStringMessage("Can't open uri " + aURI.spec);

We should not add this since it shows a URL and breaks privacy

>diff --git a/mobile/android/locales/jar.mn b/mobile/android/locales/jar.mn

>   locale/@AB_CD@/browser/payments.properties      (%chrome/payments.properties)
>+  locale/@AB_CD@/browser/handling.properties    (%chrome/handling.properties)

align better

r+ but we really need to remove the log
Attachment #796141 - Attachment is patch: true
Attachment #796141 - Flags: review?(mark.finkle) → review+
Comment on attachment 796141 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 792077
User impact if declined: Nothing shown when the user clicks some links
Testing completed (on m-c, etc.): Landed on mc today.
Risk to taking this patch (and alternatives if risky): Low risk. Overwrites some strings, but we've been shipping this localization file for awhile, just not using it. AFAIK, localizers have localized it, but its just never shown to people.
String or IDL/UUID changes made by this patch: This fixes up some configuration files to bundle things correctly. i.e. we're shipping the same strings as always, we're just using the right ones now.
Attachment #796141 - Flags: approval-mozilla-beta?
Attachment #796141 - Flags: approval-mozilla-aurora?
Comment on attachment 796141 [details] [diff] [review]
Patch

Although a nice to have, as long as we are functionally correct I do not want to rush this in our final beta's so approving on aurora only at this time.
Attachment #796141 - Flags: approval-mozilla-beta?
Attachment #796141 - Flags: approval-mozilla-beta-
Attachment #796141 - Flags: approval-mozilla-aurora?
Attachment #796141 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/7fd6c2e59b65
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.