909867 - mach mercurial-setup fails on Windows with "AttributeError: 'module' object has no attribute 'whichError'"

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Ed Morley [:emorley]]

$ mach mercurial-setup
Error running mach:

    ['mercurial-setup']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'module' object has no attribute 'whichError'

  File "c:\src-gecko\inbound\tools/mercurial/mach_commands.py", line 29, in mercurial_bootstrap
    result = wizard.run(os.path.expanduser('~/.hgrc'))
  File "c:\src-gecko\inbound\tools/mercurial\hgsetup\wizard.py", line 96, in run
    except which.whichError as e:


$ python --version
Python 2.7.3

$ hg --version
Mercurial Distributed SCM (version 2.7)

$ hg ident
e7b8ca38851d tip

Comment 1

[Gregory Szorc [:gps]]

Should be WhichError, not whichError. Derp. This patch isn't worthy of bug/review overhead.

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/e45c455f085a