Closed Bug 909888 Opened 8 years ago Closed 8 years ago

Add mach command to run remote reftests and crashtests

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file, 4 obsolete files)

Attached patch reftest_commands (obsolete) — Splinter Review
Add b2g mach commands for reftest and crashtest
Attachment #796188 - Flags: review?(jgriffin)
Attached patch Patch 1.0 - reftest commands (obsolete) — Splinter Review
Sorry, forgot to qrefresh
Attachment #796188 - Attachment is obsolete: true
Attachment #796188 - Flags: review?(jgriffin)
Attachment #796191 - Flags: review?(jgriffin)
Attached patch Patch 1.0 - reftest commands (obsolete) — Splinter Review
Still not quite what I wanted.. Let's just pretend this is the first comment. Sorry for the bugspam!
Attachment #796191 - Attachment is obsolete: true
Attachment #796191 - Flags: review?(jgriffin)
Attachment #796194 - Flags: review?(jgriffin)
Comment on attachment 796194 [details] [diff] [review]
Patch 1.0 - reftest commands

Review of attachment 796194 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/mach_commands.py
@@ +110,5 @@
> +        parser = reftest.B2GOptions()
> +        options, args = parser.parse_args([])
> +
> +        options.b2gPath = b2g_home
> +        options.adbPath = os.environ['ADB_PATH']

If someone has built B2G, they already have adb available at e.g., $b2g/out/host/linux-x86/bin.  Can we deduce the correct location of this and use this path instead?
Attachment #796194 - Flags: review?(jgriffin) → review+
Attached patch Patch 2.0 - reftest commands (obsolete) — Splinter Review
Good catch! That was a placeholder to get things working that I forgot to remove. I checked with the B2G build system and everything either assumes adb is on the path, or hardcodes out/host/linux-x86.

This patch just adds a check and raises a helpful error message if adb is not on the path. (Added the check to the mochitest command too for consistency). I'll file a separate bug to properly find the adb binary if it isn't already on the PATH.

Carrying r+ forward.
Attachment #796194 - Attachment is obsolete: true
Attachment #797272 - Flags: review+
Bah sorry for the DONTBUILD. I had a brain fart and forgot this patch also modified runreftestb2g.py.

This version includes the bustage fix. This is not my greatest bug.
Attachment #797272 - Attachment is obsolete: true
Attachment #797363 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/6ec9bb4eedf8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.