909888 - Add mach command to run remote reftests and crashtests

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Andrew Halberstadt [:ahal]]

Attachment: reftest_commands

Add b2g mach commands for reftest and crashtest

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - reftest commands

Sorry, forgot to qrefresh

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - reftest commands

Still not quite what I wanted.. Let's just pretend this is the first comment. Sorry for the bugspam!

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 796194 [details] [diff] [review]
Patch 1.0 - reftest commands

Review of attachment 796194 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/mach_commands.py
@@ +110,5 @@
> +        parser = reftest.B2GOptions()
> +        options, args = parser.parse_args([])
> +
> +        options.b2gPath = b2g_home
> +        options.adbPath = os.environ['ADB_PATH']

If someone has built B2G, they already have adb available at e.g., $b2g/out/host/linux-x86/bin.  Can we deduce the correct location of this and use this path instead?

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 2.0 - reftest commands

Good catch! That was a placeholder to get things working that I forgot to remove. I checked with the B2G build system and everything either assumes adb is on the path, or hardcodes out/host/linux-x86.

This patch just adds a check and raises a helpful error message if adb is not on the path. (Added the check to the mochitest command too for consistency). I'll file a separate bug to properly find the adb binary if it isn't already on the PATH.

Carrying r+ forward.

Comment 5

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c25245410c5

Comment 6

[Ryan VanderMeulen (PTO, back July 27)]

Backed out for torching B2G tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b1af46906bf

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Patch 3.0 - reftest commands

Bah sorry for the DONTBUILD. I had a brain fart and forgot this patch also modified runreftestb2g.py.

This version includes the bustage fix. This is not my greatest bug.

Comment 8

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ec9bb4eedf8

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6ec9bb4eedf8