909911 - Remove webapps-sync-install and webapps-sync-uninstall observers

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Marco Castelluccio [:marco]]

For webapps-sync-install we can use the DOMApplicationRegistry.confirmInstall callback, for webapps-sync-uninstall we can use webapps-uninstall.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Remove webapps-sync-install

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 796833 [details] [diff] [review]
Remove webapps-sync-install

This looks fine to me. If android was the only user of the "webapps-sync-*" notifications then removing them from Webapps.jsm seems like a good idea. I still think you should get a feedback+ or review+ from Fabrice, just so they are aware the notifications are going away.

Comment 3

[Marco Castelluccio [:marco]]

I've sent the patch to try, but b2g builds aren't working right now: https://tbpl.mozilla.org/?tree=Try&rev=48c266b6804b

The patch doesn't modify anything for b2g, so I think it should be fine to land it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/6ca07e89167e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ca07e89167e