Closed
Bug 909940
Opened 11 years ago
Closed 11 years ago
Default keyboard on HTC One only swipes first word in awesome screen
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox24 unaffected, firefox25+ verified, firefox26+ verified, firefox27 verified, fennec25+)
VERIFIED
FIXED
Firefox 27
People
(Reporter: mjrosenb, Assigned: jchen)
References
Details
Attachments
(2 files)
2.37 KB,
patch
|
cpeterson
:
review+
akeybl
:
approval-mozilla-aurora+
akeybl
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
2.42 KB,
patch
|
jchen
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
When I'm going to search for something, after opening a new tab, I can swipe the first word of my search just fine. Then I hit space to get a new word, and go to swipe a second word, I don't get the trail of where I swiped, each letter highlights individually, and when I lift my finger, I only get the last character that I swiped. After this, everything seems to work normally. IIRC, the htc one is the first phone to use sense 5.0.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → nchen
OS: Linux → Android
Hardware: x86_64 → All
Reporter | ||
Comment 1•11 years ago
|
||
Ok, small update. previously, I was not sure if this was actually a bug with fennec, or it is just the sense keyboard being broken. It works with the current beta, so this is a regression in functionality.
Comment 2•11 years ago
|
||
Can repo on a HTC One X+ running sense 5. Steps: * Make sure Firefox is not running * Start Firefox * Tap the awesome screen * Swipe a word * Press space * Swipe a second word Note skipping the space button step allows you to enter more than one word without issue. You can also repo in an already running Firefox by opening a new tab and following the steps from the 3rd bullet. Unsure if 25 is affected. Will need to use MOZ_LINKER_ONDEMAND=0 environment variable to find a regression range due to bug 907957.
Assignee | ||
Comment 3•11 years ago
|
||
Can you try these builds? http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nchen@mozilla.com-7bbd79623839/try-android/fennec-26.0a1.en-US.android-arm.apk http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nchen@mozilla.com-b0f79e244137/try-android/fennec-26.0a1.en-US.android-arm.apk
Status: NEW → ASSIGNED
Reporter | ||
Comment 4•11 years ago
|
||
I tried both of these, and they both seem to exhibit the broken behavior (I am only 99.9% certain that I actually tried both builds)
Assignee | ||
Comment 5•11 years ago
|
||
Here are two new builds you can try, http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nchen@mozilla.com-c2453e24bb92/try-android/fennec-26.0a1.en-US.android-arm.apk http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nchen@mozilla.com-e656c062d3c7/try-android/fennec-26.0a1.en-US.android-arm.apk Thanks!
Updated•11 years ago
|
Reporter | ||
Comment 6•11 years ago
|
||
Just tried both of the latest builds, and neither one worked.
Comment 7•11 years ago
|
||
2013-07-15 good - ff0a372e3170 2013-07-16 crash 2013-07-19 crash 2013-07-22 crash 2013-07-23 crash 2013-07-24 bad - 2983ca6d4d1a http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ff0a372e3170&tochange=2983ca6d4d1a bug 886508 bug 895236 bug 891316 All seem like candidates during that range.
tracking-fennec: --- → ?
Updated•11 years ago
|
tracking-fennec: ? → 25+
Reporter | ||
Comment 8•11 years ago
|
||
Not sure if this is a separate issue, but following the STR on fennec-23 and fennec-24 produces "Unfortunately, HTC Sense Input has stopped". I don't know if I've seen it in portrait mode, but I have certainly seen it in landscape mode.
Assignee | ||
Comment 9•11 years ago
|
||
Here's a build with URL/search detection disabled for HTC keyboards, http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/nchen@mozilla.com-a4b54f9f77b1/try-android/fennec-26.0a1.en-US.android-arm.apk
Flags: needinfo?(mrosenberg)
Reporter | ||
Comment 10•11 years ago
|
||
ok, just tried that one on my htc one, and it seems to work correctly. (the crashes were a tad non-deterministic before)
Flags: needinfo?(mrosenberg)
Comment 12•11 years ago
|
||
The build in comment 9 also fixes bug 919634.
Assignee | ||
Comment 13•11 years ago
|
||
The HTC keyboard is prone to crashing and misbehaving in general when we switch its type dynamically. We should just disable that for now.
Attachment #808733 -
Flags: review?(cpeterson)
Comment 14•11 years ago
|
||
Comment on attachment 808733 [details] [diff] [review] Disable updating the URL bar type for HTC keyboards (v1) Review of attachment 808733 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #808733 -
Flags: review?(cpeterson) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 15•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/80613c46eae2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/80613c46eae2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Comment 17•11 years ago
|
||
Any chance of this being uplifted at all, or are we just going to have to wait until January 21st for the fix? Additional Information: This affects any device using the HTC Sense 4+ or higher (maybe 4.0 and higher) keyboard. This has been in issue/annoyance for a while, but I just never bothered to file a bug report on it. It has also existed in several (if not all) release builds.
Comment 18•11 years ago
|
||
This is tracking 25+ so I would imagine we can get this into Firefox Beta shortly assuming a low risk evaluation assessment.
Updated•11 years ago
|
Flags: needinfo?(nchen)
Assignee | ||
Comment 19•11 years ago
|
||
Comment on attachment 808733 [details] [diff] [review] Disable updating the URL bar type for HTC keyboards (v1) [Approval Request Comment] Bug caused by (feature/regressing bug #): N/A User impact if declined: Keyboard can misbehave and/or crash on HTC devices when using the URL bar Testing completed (on m-c, etc.): m-c, locally Risk to taking this patch (and alternatives if risky): Very small; only affects HTC devices String or IDL/UUID changes made by this patch: None
Attachment #808733 -
Flags: approval-mozilla-beta?
Attachment #808733 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(nchen)
Comment 20•11 years ago
|
||
Comment on attachment 808733 [details] [diff] [review] Disable updating the URL bar type for HTC keyboards (v1) I hate taking input changes in the last couple of weeks of a release, but we'll make an exception here to prevent a new regression for HTC users.
Attachment #808733 -
Flags: approval-mozilla-beta?
Attachment #808733 -
Flags: approval-mozilla-beta+
Attachment #808733 -
Flags: approval-mozilla-aurora?
Attachment #808733 -
Flags: approval-mozilla-aurora+
Comment 21•11 years ago
|
||
And as a reminder, regressions of this nature should be nominated for tracking-firefox
tracking-firefox25:
--- → +
tracking-firefox26:
--- → +
Comment 22•11 years ago
|
||
(In reply to Alex Keybl [:akeybl] from comment #21) > And as a reminder, regressions of this nature should be nominated for > tracking-firefox based on comment 17, I don't know that this is a regression
Comment 23•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/77e2a30105df Needs a branch-specific patch for the beta uplift.
Assignee | ||
Comment 24•11 years ago
|
||
Comment 25•11 years ago
|
||
Thank you kindly :) https://hg.mozilla.org/releases/mozilla-beta/rev/45d556c1c19e
Keywords: branch-patch-needed
Updated•11 years ago
|
Attachment #814935 -
Flags: checkin? → checkin+
Comment 26•11 years ago
|
||
Bustage fix: https://hg.mozilla.org/releases/mozilla-beta/rev/6da6f43203ca
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Flags: needinfo?(aaron.train)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•