909991 - [Helix] Labels in browser settings are so small it's hard to read

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2013-08-27-19-03-52.png

1. install 1.5 DPI Helix build ( gaia : 2e8d9135f87357db2af59ef4917cf8b0918f5df2 )
2. launch browser
3. open the tab tray
4. select the settings icon

Expected: labels on the settings buttons are easy to read
Actual: they are really small.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

It could be a regression of Bug 839194. After reverting, the button looks fine.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

add <!-- <link rel="stylesheet" href="shared/style/buttons.css"> --> in index.html.

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 796561 [details]
PR to master

Thanks for fixing this, was my fault

Comment 5

[Dale Harvey (:daleharvey)]

One small note, in future can you avoid putting tags ([Helix]) in the commit message, they can live inside the whiteboard / keywords here if they are needed.

Comment 6

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/3a514b96dd7b9004f5ad89340ffd2455fa2347e4