Token Server User Flow doc should note HAWK protocol usage

VERIFIED FIXED

Status

Cloud Services
Server: Token
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: Sam Penrose, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Per 820643, the token service is migrating to speak the HAWK protocol. The current documentation at http://docs.services.mozilla.com/token/user-flow.html only mentions MACAuth. It should be updated.
(Assignee)

Updated

5 years ago
Blocks: 820643
Whiteboard: [qa+]
(Assignee)

Updated

4 years ago
Blocks: 951987
(Assignee)

Comment 1

4 years ago
Created attachment 8349867 [details] [diff] [review]
replace "mac auth" with "hawk auth" in tokenserver protocol docs

Yep, this is happening.  Pinging :telliott for review but mostly just to turn our shared attentions towards the docs situation in general.
Attachment #8349867 - Flags: review?(telliott)
Is the canonical implementation of the tokenserver still here? https://github.com/mozilla-services/tokenserver

Because I don't see any changes to use MAC auth there.
(Assignee)

Comment 3

4 years ago
> Is the canonical implementation of the tokenserver still here? https://github.com/mozilla-services/tokenserver

It is.

> Because I don't see any changes to use MAC auth there.

There doesn't need to be.  The mac => hawk transition only affects downstream services that consume tokenserver-provided credentials, the tokenserver itself will continue to work as-is.
Ah, pretty neat! (happy to see this was future proof).

That remembers me a comment saying we should specify in the response from the server what is the type of the token we return. 

See https://github.com/mozilla-services/tokenserver/blob/master/tokenserver/views.py#L206
Attachment #8349867 - Flags: review?(telliott) → review+
(Assignee)

Comment 5

4 years ago
I'm a bit sad to close a bug with such an awesome bug number, but here we go:

https://github.com/mozilla-services/docs/commit/6a3c3b7bf2c68146b0346573c88be9ff25b066dd
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Verified here: https://github.com/mozilla-services/docs
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.