Closed
Bug 910014
Opened 11 years ago
Closed 11 years ago
[bedrock][newsletter] update - FFx & You signup success message
Categories
(www.mozilla.org :: Newsletters, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jdavis, Assigned: dpoirier)
References
()
Details
(Whiteboard: [kb=1106070] )
Attachments
(2 files)
When you sign up for a Firefox & You newsletter on bedrock you get the simple success message of "Thanks for signing up!"
This should be changed to:
"Thanks! Please check your inbox to confirm your subscription.
You'll receive an email from mozilla@e.mozilla.org to confirm your subscription. If you don't see it, please check your spam filter. You must confirm your subscription to receive our newsletter."
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dpoirier
Assignee | ||
Comment 1•11 years ago
|
||
Pull request opened: https://github.com/mozilla/bedrock/pull/1200
Updated•11 years ago
|
Whiteboard: [kb=1106070]
Comment 2•11 years ago
|
||
Flod, we need to localize these strings before we can merge. Should I open a separate bug?
Flags: needinfo?(francesco.lodolo)
Comment 3•11 years ago
|
||
Apparently not necessary, both those strings are in our newsletter.lang from long ago (r104999 to be more precise).
Flags: needinfo?(francesco.lodolo)
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/92dab63f6f5bbf80d01ff857b08f95d547ec3063
Bug 910014 - Success message on Firefox & You signup
When you signup for the Firefox & You newsletter at
https://www.mozilla.org/firefox/os/ or
https://www.mozilla.org/firefox/fx, change the success
message.
https://github.com/mozilla/bedrock/commit/fc0951241e7dd5f0a7a5758e753ce3f2c7aa843b
Merge pull request #1200 from dpoirier/bug-910014-ff-and-you-signup-message
Bug 910014 - Success message on Firefox & You signup
Assignee | ||
Comment 5•11 years ago
|
||
Jess: changes have been merged, should be ready to test on -dev in 15-20 minutes.
Reporter | ||
Comment 6•11 years ago
|
||
Howdy! This looks like it went live - and it looks like there are l10n strings missing for some reason? I know they exist - does something need to be done to it so that it shows up in the right places on bedrock?
See attached screenshot.
Sidenote: Mike/Dan, Is there a way to know what's going live before it goes live? I just found this by testing a different bug that did go live with a Prod push yesterday (Bug 908633)
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(dpoirier)
Comment 7•11 years ago
|
||
If we want things to go through more testing before going live than what QA already does, it should be put on a demo server. Things that are merged to master (and are on www-dev) are assumed to be ready to deploy at any time.
We were told this string was translated. I'll take a look at why this isn't working.
Reporter | ||
Comment 8•11 years ago
|
||
The strings exist on l10n on the php site. I think the problem may be that the localized strings don't exist on bedrock.
Flags: needinfo?(dpoirier)
Comment 9•11 years ago
|
||
It's because the string was changed slightly.
OLD: If you don't see it, check your spam filter.
NEW: If you don't see it, please check your spam filter.
Removing the "please" fixes it. Shall I do that for all the places?
Flags: needinfo?(francesco.lodolo) → needinfo?(jdavis)
Comment 10•11 years ago
|
||
Pointer to Github pull-request
Comment 11•11 years ago
|
||
PR above fixes the strings. Let me know if that's how we'd like to proceed and I can get that merged.
Reporter | ||
Comment 12•11 years ago
|
||
Please remove 'please' for now and merge away. Thank you!
Flags: needinfo?(jdavis)
Comment 13•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/a7a564c773ca7ea76a25a39c44a1d6aa17e21b34
Fix bug 910014: Correct newsletter success string for l10n.
https://github.com/mozilla/bedrock/commit/1927a8f16df20d09b143af271f93c1783a5b7909
Merge pull request #1228 from pmclanahan/fix-l10n-string-newsletter-success-910014
Fix bug 910014: Correct newsletter success string for l10n.
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 14•11 years ago
|
||
This went live this past week. Thanks!
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•