If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

make export at top-level doesn't recurse js/src

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla26
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
That's due to js.mozbuild doing this:
  add_tier_dir('js', 'js/src', static=True)

It does it so that js/src is not traversed for moz.build files, but static=True also means js/src is not considered as a directory traversed with (export, libs, tools).
(Assignee)

Comment 2

4 years ago
Created attachment 796451 [details] [diff] [review]
Treat js/src differently from other "static" directories

'external' is probably a poorly chosen term, but what i mean to do here is add a class of directories for which we don't traverse for moz.build, but that are built with (export, libs, tools)
Attachment #796451 - Flags: review?(gps)

Comment 3

4 years ago
Comment on attachment 796451 [details] [diff] [review]
Treat js/src differently from other "static" directories

Review of attachment 796451 [details] [diff] [review]:
-----------------------------------------------------------------

Please document this in sandbox_symbols.py.

I also wish there were tests for this. But I have a feeling all this tiers foo will likely change soon, so no sense worrying about it too much.
Attachment #796451 - Flags: review?(gps) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/82379a4b4063

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/82379a4b4063
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Depends on: 941120
You need to log in before you can comment on or make changes to this bug.