910096 - make export at top-level doesn't recurse js/src

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

That's due to js.mozbuild doing this:
  add_tier_dir('js', 'js/src', static=True)

It does it so that js/src is not traversed for moz.build files, but static=True also means js/src is not considered as a directory traversed with (export, libs, tools).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Treat js/src differently from other "static" directories

'external' is probably a poorly chosen term, but what i mean to do here is add a class of directories for which we don't traverse for moz.build, but that are built with (export, libs, tools)

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 796451 [details] [diff] [review]
Treat js/src differently from other "static" directories

Review of attachment 796451 [details] [diff] [review]:
-----------------------------------------------------------------

Please document this in sandbox_symbols.py.

I also wish there were tests for this. But I have a feeling all this tiers foo will likely change soon, so no sense worrying about it too much.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82379a4b4063

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/82379a4b4063