910149 - [browserid] Going to a @login_required view sends user to non-Persona login page

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect, P2)

Description

[Ricky Rosario [:rrosario, :r1cky]]

If you aren't authed and go to https://support.allizom.org/en-US/kb/new, for example, you are redirected to the old login page:

https://support.allizom.org/en-US/users/auth?next=%2Fen-US%2Fkb%2Fnew

A simple solution to this is to change that login page to have some message telling the user to sign in with email.

Making this 2pts but it might be 1pt.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now:
https://github.com/mozilla/kitsune/commit/45bb5d04799e8f1364ce8f24da0c3dd6e450754f

PR was here:
https://github.com/mozilla/kitsune/pull/1602

Comment 2

[[:AndreiH]]

Thanks for the fix Ricky.
This has been partially resolved. When going to https://support.allizom.org/en-US/kb/new I can see on the page 2 ways user can "Sign in": http://screencast.com/t/SAviduuS .
When clicking on option 1, yes I am redirected to the correct page ("Create new article page").
But when clicking on option 2 the bug still reproduces.
Here is a screencast:
http://screencast.com/t/C2IBtzfEgfWi

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Andrei Hutusoru from comment #2)
> But when clicking on option 2 the bug still reproduces.
> Here is a screencast:
> http://screencast.com/t/C2IBtzfEgfWi

I see.

Rehan, we should probably redirect away (to next, or home if next isn't set) from /users/auth if the user is already signed in. Does that makes sense?

Comment 4

[Rehan Dalal (Inactive)]

Landed:
https://github.com/mozilla/kitsune/commit/d304382a108bebd120b30c81771e1349af856613

Pushed to prod by Mike, last night.

Comment 5

[[:AndreiH]]

This is now Verified and Fixed. Thanks! :)