910151 - [Buri][REG][STK]should display the default text when execute get input command with default text parameter

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[sync-1]

Mozilla build ID:20130817041203
 
 
 DEFECT DESCRIPTION:
 [REG][STK]should display the default text when execute get input command with default text parameter
 
  REPRODUCING PROCEDURES:
    1. Load one simulated SIM card which can send "get input" command.
    2. Run case STM03009-> select any item in the list, the prompt message display the text string in the input box ,not the default text string,see the snapshot.--->KO
 
 
  EXPECTED BEHAVIOUR:
 if the get input command with text string and default text string, it should display the default text string in the input box.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: QXDM log on SW177_1

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: ADB log on SW177+GD

Comment 5

[sync-1]

Clone from brother

Comment 6

[sync-1]

Attachment: snapshot

Comment 7

[sync-1]

Clone from brother

Comment 8

[sync-1]

Attachment: ADB log on SW177

Comment 9

[sync-1]

Clone from brother

Comment 10

[sync-1]

Attachment: ADB log on SW177_2

Comment 11

[Preeti Raghunath(:Preeti)]

not sure what the default string in the test box should be. Please clearly state what default string is expected.

Comment 12

[buri.blff]

(In reply to Preeti Raghunath(:Preeti) from comment #11)
> not sure what the default string in the test box should be. Please clearly
> state what default string is expected.


this pr is caused for options.maxLength is invalid;

we find the Mozilla build ID:20130826041201 has add the patch:

// Workaround. See bug #818270. Followup: #895314
       setTimeout(function workaround_bug818270() {
         self.icc_input_box.maxLength = options.maxLength;
       });
we will check the patch;

Comment 13

[bhavana bajaj [:bajaj]]

Please renom if the work around does not work well and this is a true blocker with how it may impact a user

Comment 14

[buri.blff]

the patch in commont 11, is not ok;

Comment 15

[sync-1]

this is the mozilla patch:
 
 http://gerrit.tcl-ta.com:8081/#patch,sidebyside,111946,1,apps/system/js/icc.js
 please help to check in 17B;

Comment 16

[buri.blff]

Dear bbajaj:
  the patch in 818270 is not ok.

Comment 17

[Andrew Overholt [:overholt]]

(In reply to sync-1 from comment #15)
> this is the mozilla patch:
>  
>  http://gerrit.tcl-ta.com:8081/#patch,sidebyside,111946,1,apps/system/js/icc.
> js
>  please help to check in 17B;

This doesn't appear to be externally-accessible:

$ host gerrit.tcl-ta.com
Host gerrit.tcl-ta.com not found: 3(NXDOMAIN)

Fernando, can you take another stab at a workaround since it seems the timeout you added to work around bug 818270 isn't working (comment #16).  Thanks.

Comment 18

[buri.blff]

Dear [e-mail]:
Is there any progress??

the timeout patch for this pr is not ok.

Comment 19

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to buri.blff from comment #18)
> Dear [e-mail]:
> Is there any progress??
> 
> the timeout patch for this pr is not ok.

Assigned to me (first notice) on friday. Working on it this week

Comment 20

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Set default value to the input box

Is the same issue as bug #818270

This fix is a workaround. Followup: #895314

Comment 21

[buri.blff]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #20)
> Created attachment 808560 [details]
> Set default value to the input box
> 
> Is the same issue as bug #818270
> 
> This fix is a workaround. Followup: #895314

yes, set the input.maxlength second time dosen't work.

Comment 22

[buri.blff]

this pr is blocked for set the input.maxlength second time dosen't work.

Comment 23

[buri.blff]

And the the timeout patch to workaround for this pr is not ok.

Comment 24

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 808560 [details]
Set default value to the input box

Sorry for keeping you waiting.

Comment 25

[buri.blff]

Dear [e-mail]:
   Dose setting input.value will affect the input.maxLength for second time??

Comment 26

[buri.blff]

sorry, what i want to says: 
   Dose setting input.value will make the input.maxLength work well when input.maxLength is changed for second time??

Comment 27

[buri.blff]

sorry, what i want to say is as follow: 
   Dose setting input.value will make the input.maxLength work well when input.maxLength is changed for second time??

Comment 28

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to buri.blff from comment #27)
> sorry, what i want to say is as follow: 
>    Dose setting input.value will make the input.maxLength work well when
> input.maxLength is changed for second time??

Hi,

The short answer is Yes, it should ;)

In all my test, with this workaround is working perfect in the device.

I think in your case can fail because the testing suite... can your tests *delay* the screen refresh? if your test do that, a race condition can affect this.

Another way is investigate the use of MozAfterPaint [1] but not sure if it's implemented in B2G

[1] https://developer.mozilla.org/en-US/docs/Web/Reference/Events/MozAfterPaint

Comment 29

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/b15ca7b6a895035b67cc593af926dfb9e701a027

Comment 30

[buri.blff]

Dear [e-mail]:
   this patch is not ok for us.

Comment 31

[buri.blff]

We don't find this pr on v1.0.1

Comment 32

[James Lal [:lightsofapollo]]

Uplifted b15ca7b6a895035b67cc593af926dfb9e701a027 to:
v1-train: 05bca4a0c654a86b1b149131cfc96d62ed855b1d
v1.2: 9d54ad9f070183750c884c5cac25987ce3608792

Comment 33

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 05bca4a0c654a86b1b149131cfc96d62ed855b1d