910153 - [Email] email address in a plain message body is broken, when multiple sub domains present.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Leo]

STR:
1. Create an IMAP account.
2. Continue to Email -> Message box
3. Compose an Email
4. Enter an email address which has multiple sub domains.
   (ex: [e-mail])
5. Send the email

Result: 
Open the sent email, complete email address is not anchored.
for the above example it enables the link to only  "[e-mail]"

Expected: 
complete email address should be recognized and should be allowed to select.

Note:
1. This happens only with the email which has plain body ( not an HTML message)
2. Reproduced in Gaia Master also.

Comment 1

[psingapati]

Attachment: Broken Email addresses

Picture shows the email addresses that are broken

Comment 2

[Leo]

Functionality issue , leo+

Comment 3

[psingapati]

Working on this issue.

In case of plain body, email addresses REGEX not verifying the multiple sub domains.
Working on the issue patch will be uploaded to soon.

Comment 4

[psingapati]

Attachment: Pointer to PR

PR is raised to gelam, 
added multiple sub domains check to email address Regex.
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/242

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 796556 [details]
Pointer to PR

Wow, I really did not look into our e-mail reg-exp enough there previously when I cleaned up the URL logic.

Your fix works but I realized there are a number of other cases we handle poorly.  Uppercase, IDN roots, etc.  Also, we need unit tests for these things.

So I've whipped up an alternate implementation that is based more on the regex we are using for URLs which does not try and generatively build the domain segments.  The main performance reason for this is that it lets us explicitly bound the length of the string the regexp will try and consume.  The (.[a-z]+)+ could consume an arbitrarily long string; the number of segments could be bounded, but since the segments could each be rather long, the worst-case performance scenario could get very bad.

I'll attach my pull request in one sec and ask you to review.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/243

Pointer to Github pull-request

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 796864 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/243

Marcus, if you'd like to take a look at this from a code perspective, that would be great.  Note that bug 858370 is where we want to get rid of these regexps, so our goal is not so much perfection as just avoiding any obvious bloopers.

Comment 8

[Marcus Cavanaugh [:mcav]]

Comment on attachment 796864 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/243

Looks good to me; it works against any pathological cases I could come up with.

Comment 9

[psingapati]

Comment on attachment 796864 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/243

Issue is working fine with the patch.
Thanks

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

landed:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/243
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/b7f029738e1472053e883c35e3379f78bd0424f7

https://github.com/mozilla-b2g/gaia/pull/11837
https://github.com/mozilla-b2g/gaia/commit/40f43a0b0e25b0cdeb6e7c82387d1fd2517c1ac6

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 40f43a0b0e25b0cdeb6e7c82387d1fd2517c1ac6 to:
v1-train: cffe2b7d4f382a5c2239723f6598e19c8d9da732

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: cffe2b7d4f382a5c2239723f6598e19c8d9da732