Closed Bug 910166 Opened 10 years ago Closed 10 years ago

Followup bug to Update of browser graphics

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
All
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: epang, Assigned: epang)

Details

(Whiteboard: visual design)

Attachments

(1 file, 2 obsolete files)

Pull Request
46 bytes, text/x-github-pull-request
sjochimek
: review+
Details | Review 
Adding missing icons:
back-disabled.png - 1.5x, 2x
tab-background.png - 2x
button-background.png - 2x
favicon-underlay.png - 2x
Attached file Pull Request — 
Hey Sam, can you help review and land to master? Thanks!
Attachment #796609 - Flags: review?(sjochimek)
Comment on attachment 796609 [details] [review]
Pull Request

Eric, apps/browser/style/images/back-disabled.png is not used in browser app.
Why don't we just delete it ?
(In reply to Sam Joch [:samjoch] from comment #2)
> Comment on attachment 796609 [details] [review]
> Pull Request
> 
> Eric, apps/browser/style/images/back-disabled.png is not used in browser app.
> Why don't we just delete it ?

Sam, I wasn't sure.  If that's the case yes we can delete them. Can you delete them? Thanks!
I am sure you can do it by updating your pull request.

Let me know if you need help ;)
(In reply to Sam Joch [:samjoch] from comment #4)
> I am sure you can do it by updating your pull request.
> 
> Let me know if you need help ;)

Ok, I'll give it a shot.  Not sure if I know how but I'll let you know if I get stuck :). Thanks!
Assignee: pivanov → nobody
Attached file Updated Pull Request (obsolete) — 
Sam, I think I did it!  Let me know if I did anything wrong tho.  Thanks!
Attachment #797156 - Flags: review?(sjochimek)
Attached file Updated Pull Request (obsolete) — 
Put the wrong link to the pull request before.
Attachment #797156 - Attachment is obsolete: true
Attachment #797156 - Flags: review?(sjochimek)
Attachment #797157 - Flags: review?(sjochimek)
Comment on attachment 796609 [details] [review]
Pull Request

Landed in master
Attachment #796609 - Flags: review?(sjochimek) → review+
Attachment #797157 - Attachment is obsolete: true
Attachment #797157 - Flags: review?(sjochimek)
(In reply to Sam Joch [:samjoch] from comment #9)
> master:
> https://github.com/mozilla-b2g/gaia/commit/
> 407fbfb6a9de68ec4db2f0f3dc6c67463e293f47

thanks Sam! Naoki, this should be ready for verification, thanks!
Flags: needinfo?(nhirata.bugzilla)
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(nhirata.bugzilla)
Resolution: --- → FIXED
verified on 2013-09-04-04-02-05 helix; unagi 2013-08-28-15-52-34 build; 2013-09-04-04-02-05 buri
Status: RESOLVED → VERIFIED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
Assignee: nobody → epang
You need to log in before you can comment on or make changes to this bug.