910168 - When long pressing u key in Spanish keyboard, the first suggested letter is ü, it should be ú

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Beatriz Rodríguez [:brg]]

In Spanish language, the character ú is more often used than character ü.
We would like to ask to modify the suggestion of caracters when long pressing key u in Spanish keyboard.

Tested using v1-train and master. The result is the same.
Nominating to koi as improvement.

Comment 1

[Corey Frang [:gnarf]]

Attachment: patch v1

Seems like a simple change - Is there a good place to "test" (read: unit?) this (other than by trying on the device, which I have done)

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 812351 [details] [diff] [review]
patch v1

Looks good for this simple.
Thanks for looking into this.

Corey, no, we don't have the unit tests for the layout related stuff right now.

Comment 3

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/3df055e97bd547049f2eb2abac5a5f66e7ca2ee2

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 3df055e97bd547049f2eb2abac5a5f66e7ca2ee2 to:
v1.2: 581eef48741cc8880b5a65122d9700c5b67f6054

Comment 5

[Beatriz Rodríguez [:brg]]

Thanks everyone for this change.
I have verified it in unagi- with Spanish keyboard in:
v1-2: Gecko-c038ee4.Gaia-0a9c648
master Gecko-03b8350.Gaia-952234a

Comment 6

[Lucas Aliaga]

Verified Fixed in latest 1.2 aurora Buri. The accented u is default when long pressing the key on spanish keyboard.

Environment:
Gaia   dbcc171eae6b4d9d168a48291d5ea54c7580561a
SourceStamp 7ca5d1e81d37
BuildID 20131017004001
Version 26.0a2