Closed Bug 910168 Opened 7 years ago Closed 7 years ago

When long pressing u key in Spanish keyboard, the first suggested letter is ü, it should be ú

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:koi+, b2g-v1.2 verified)

VERIFIED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- verified

People

(Reporter: brg, Assigned: gnarf)

Details

(Whiteboard: [good first bug][mentor=rudyl])

Attachments

(1 file)

In Spanish language, the character ú is more often used than character ü.
We would like to ask to modify the suggestion of caracters when long pressing key u in Spanish keyboard.

Tested using v1-train and master. The result is the same.
Nominating to koi as improvement.
Assignee: nobody → rlu
blocking-b2g: koi? → koi+
Whiteboard: [good first bug][mentor=rudyl]
Assignee: rlu → gnarf37
Attached patch patch v1Splinter Review
Seems like a simple change - Is there a good place to "test" (read: unit?) this (other than by trying on the device, which I have done)
Attachment #812351 - Flags: review?(rlu)
Comment on attachment 812351 [details] [diff] [review]
patch v1

Looks good for this simple.
Thanks for looking into this.

Corey, no, we don't have the unit tests for the layout related stuff right now.
Attachment #812351 - Flags: review?(rlu) → review+
master: https://github.com/mozilla-b2g/gaia/commit/3df055e97bd547049f2eb2abac5a5f66e7ca2ee2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted 3df055e97bd547049f2eb2abac5a5f66e7ca2ee2 to:
v1.2: 581eef48741cc8880b5a65122d9700c5b67f6054
Thanks everyone for this change.
I have verified it in unagi- with Spanish keyboard in:
v1-2: Gecko-c038ee4.Gaia-0a9c648
master Gecko-03b8350.Gaia-952234a
Status: RESOLVED → VERIFIED
Verified Fixed in latest 1.2 aurora Buri. The accented u is default when long pressing the key on spanish keyboard.

Environment:
Gaia   dbcc171eae6b4d9d168a48291d5ea54c7580561a
SourceStamp 7ca5d1e81d37
BuildID 20131017004001
Version 26.0a2
You need to log in before you can comment on or make changes to this bug.