Closed
Bug 910210
Opened 11 years ago
Closed 11 years ago
Overlay.update() should accept an optional parameter to override internal counter
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sergi, Assigned: sergi)
Details
Attachments
(1 file)
46 bytes,
patch
|
arcturus
:
review+
|
Details | Diff | Splinter Review |
When testing streaming import for massive vcard files, it is convenient to update the progress var in a set interval, to avoid updating it (and touching DOM) hundreds of times per second. It would be good to have an optional parameter to `update` in order to set the progress value, instead of calling the method every time the counter value is incremented by one.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #796616 -
Flags: review?(francisco.jordano)
Updated•11 years ago
|
blocking-b2g: --- → koi?
Comment 2•11 years ago
|
||
Comment on attachment 796616 [details] [diff] [review] GitHub PR Hi Sergi, just added a small comment. I know, a bit picky, but just to be sure that we don't shoot our self in the foot ;)
Comment 3•11 years ago
|
||
does not seem like a blocker. if you feel that there is a great user impact on this, please explain and renom. Thanks
blocking-b2g: koi? → ---
Comment 4•11 years ago
|
||
Comment on attachment 796616 [details] [diff] [review] GitHub PR Good work, clean and simple.
Attachment #796616 -
Flags: review?(francisco.jordano) → review+
Comment 5•11 years ago
|
||
Regarding the koi? ... is this blocking a koi? Sergi? I mean, this was part of the work you are doing about changing the import from sdcard to an streaming approach. Actually, bug 904313 that is nominated to leo? Do you think it should be leo? then? Thanks!
Flags: needinfo?(sergi.mansilla)
Assignee | ||
Comment 6•11 years ago
|
||
I don't think it should be leo. Thanks for your review!
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(sergi.mansilla)
Resolution: --- → FIXED
Updated•10 years ago
|
Assignee: nobody → sergi.mansilla
You need to log in
before you can comment on or make changes to this bug.
Description
•