Closed Bug 910210 Opened 8 years ago Closed 8 years ago

Overlay.update() should accept an optional parameter to override internal counter

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sergi, Assigned: sergi)

Details

Attachments

(1 file)

When testing streaming import for massive vcard files, it is convenient to update the progress var in a set interval, to avoid updating it (and touching DOM) hundreds of times per second. It would be good to have an optional parameter to `update` in order to set the progress value, instead of calling the method every time the counter value is incremented by one.
Attached patch GitHub PRSplinter Review
Attachment #796616 - Flags: review?(francisco.jordano)
blocking-b2g: --- → koi?
Comment on attachment 796616 [details] [diff] [review]
GitHub PR

Hi Sergi, just added a small comment. I know, a bit picky, but just to be sure that we don't shoot our self in the foot ;)
does not seem like a blocker.
if you feel that there is a great user impact on this, please explain and renom.
Thanks
blocking-b2g: koi? → ---
Comment on attachment 796616 [details] [diff] [review]
GitHub PR

Good work, clean and simple.
Attachment #796616 - Flags: review?(francisco.jordano) → review+
Regarding the koi? ... is this blocking a koi? Sergi?

I mean, this was part of the work you are doing about changing the import from sdcard to an streaming approach.

Actually, bug 904313 that is nominated to leo?

Do you think it should be leo? then?

Thanks!
Flags: needinfo?(sergi.mansilla)
I don't think it should be leo. Thanks for your review!
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(sergi.mansilla)
Resolution: --- → FIXED
Assignee: nobody → sergi.mansilla
You need to log in before you can comment on or make changes to this bug.