Closed Bug 910238 Opened 9 years ago Closed 9 years ago

Don't put content dirs in LOCAL_INCLUDES in accessible

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(3 files)

Part a: Remove includes from HTMLInputElement.h
2.50 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part b: Export nsImageLoadingContent.h
654 bytes, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Part c: Remove content dirs from LOCAL_INCLUDES
1.28 KB, patch
tbsaunde
: review+
Details | Diff | Splinter Review 
The main issue here is that code tries to include "TreeWalker.h", which means different things based on the order of LOCAL_INCLUDES. That's rather too brittle for my liking.
nsTextEditorState.h in particular, because it isn't exported.
Attachment #796657 - Flags: review?(bzbarsky)
HTMLInputElement.h needs it.
Attachment #796661 - Flags: review?(bzbarsky)
Comment on attachment 796663 [details] [diff] [review]
Part c: Remove content dirs from LOCAL_INCLUDES

other than the ones you decided wheren't actually private? :-)
Attachment #796663 - Flags: review?(trev.saunders) → review+
Blocks: 910253
Comment on attachment 796657 [details] [diff] [review]
Part a: Remove includes from HTMLInputElement.h

r=me
Attachment #796657 - Flags: review?(bzbarsky) → review+
Comment on attachment 796661 [details] [diff] [review]
Part b: Export nsImageLoadingContent.h

I guess HTMLInputElement sort of needs this.  :(  OK.
Attachment #796661 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/dabe2b54a50b
https://hg.mozilla.org/mozilla-central/rev/297b9822b054
https://hg.mozilla.org/mozilla-central/rev/8f6dcb016661
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.