Closed
Bug 910238
Opened 12 years ago
Closed 12 years ago
Don't put content dirs in LOCAL_INCLUDES in accessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(3 files)
|
2.50 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
654 bytes,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
1.28 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
The main issue here is that code tries to include "TreeWalker.h", which means different things based on the order of LOCAL_INCLUDES. That's rather too brittle for my liking.
|
Assignee | |
Comment 1•12 years ago
|
||
nsTextEditorState.h in particular, because it isn't exported.
Attachment #796657 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•12 years ago
|
||
HTMLInputElement.h needs it.
Attachment #796661 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #796663 -
Flags: review?(trev.saunders)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 796663 [details] [diff] [review]
Part c: Remove content dirs from LOCAL_INCLUDES
other than the ones you decided wheren't actually private? :-)
Attachment #796663 -
Flags: review?(trev.saunders) → review+
|
||
Comment 5•12 years ago
|
||
Comment on attachment 796657 [details] [diff] [review]
Part a: Remove includes from HTMLInputElement.h
r=me
Attachment #796657 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 6•12 years ago
|
||
Comment on attachment 796661 [details] [diff] [review]
Part b: Export nsImageLoadingContent.h
I guess HTMLInputElement sort of needs this. :( OK.
Attachment #796661 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dabe2b54a50b
https://hg.mozilla.org/mozilla-central/rev/297b9822b054
https://hg.mozilla.org/mozilla-central/rev/8f6dcb016661
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•