910271 - "ReferenceError: a is not defined | undefined | 45" in all jsreftest regress-446026-01.js runs

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Due to recent TBPL log parser improvements, we are catching more errors in the logs than we used to.

https://tbpl.mozilla.org/php/getParsedLog.php?id=27115515&tree=Mozilla-Central

Ubuntu VM 12.04 mozilla-central opt test jsreftest on 2013-08-28 06:01:37 PDT for push 44e615a66f3f
slave: tst-linux32-ec2-329

06:11:26     INFO -  REFTEST TEST-START | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-446026-01.js
06:11:26     INFO -  REFTEST TEST-LOAD | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-446026-01.js | 1999 / 6601 (30%)
06:11:26     INFO -  BUGNUMBER: 446026
06:11:26     INFO -  STATUS: brian loves eval(s, o)
06:11:26     INFO -  JavaScript warning: file:///builds/slave/test/build/tests/jsreftest/tests/js1_5/Scope/regress-446026-01.js, line 32: Support for eval(code, scopeObject) has been removed. Use |with (scopeObject) eval(code);| instead.
06:11:26     INFO -  ReferenceError: a is not defined | undefined | 45
06:11:26     INFO -  1
06:11:26     INFO -  REFTEST TEST-PASS | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-446026-01.js | brian loves eval(s, o)  item 1
06:11:26     INFO -  REFTEST TEST-PASS | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-446026-01.js | brian loves eval(s, o)  item 2
06:11:26     INFO -  REFTEST INFO | Loading a blank page
06:11:26     INFO -  REFTEST TEST-END | file:///builds/slave/test/build/tests/jsreftest/tests/jsreftest.html?test=js1_5/Scope/regress-446026-01.js

Comment 1

[Boris Zbarsky [:bzbarsky]]

Is the issue here this line in the test:

36 print(actual += " | " + foo + " | " + bar); // 21

here "actual" is an exception, so this will print a line starting with "ReferenceError: a is not defined" to the log.

Should the test just be printing something in front of that line?  Or is the log parser being over-eager here?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

403 edmorley

Comment 3

[Ed Morley [:emorley]]

Guess we just need bug 829684.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=32535402&tree=Mozilla-Aurora