Closed Bug 910295 Opened 11 years ago Closed 2 years ago

TEST-UNEXPECTED-FAIL | folder-display/test-message-commands.js | test-message-commands.js::test_tag_keys_disabled_in_content_tab

Categories

(Thunderbird :: Folder and Message Lists, defect)

Product:
Thunderbird
Component:
Folder and Message Lists
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: standard8, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

patch
3.16 KB, patch
mkmelin
: review+
Details | Diff | Splinter Review 
Mac failure only so far:

https://tbpl.mozilla.org/php/getParsedLog.php?id=27075431&tree=Thunderbird-Trunk#error0

TEST-START | /builds/slave/talos-slave/test/build/mozmill/folder-display/test-message-commands.js | test_tag_keys_disabled_in_content_tab
Test Failure: Timeout waiting for the content tab page to load.
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://mozapps/content/extensions/extensions.js :: gVC_shutdown :: line 524"  data: no]
************************************************************
++DOMWINDOW == 90 (0x13b49bdc8) [serial = 635] [outer = 0x115acf008]
###!!! ASSERTION: Shouldn't be trying to restyle non-elements directly: '!aContent || aContent->IsElement()', file ../../../../mozilla/layout/base/nsStyleChangeList.cpp, line 62
++DOMWINDOW == 91 (0x13b41c288) [serial = 636] [outer = 0x115acf008]
--DOCSHELL 0x13c661700 == 17 [id = 110]
--DOCSHELL 0x13a9d0210 == 16 [id = 68]
--DOCSHELL 0x114c6ed50 == 15 [id = 108]
WARNING: NS_ENSURE_TRUE(mScriptGlobalObject) failed: file ../../../../../../mozilla/content/xul/document/src/XULDocument.cpp, line 3682
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file ../../../../../mozilla/content/base/src/nsFrameLoader.cpp, line 401
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
WARNING: NS_ENSURE_TRUE(context) failed: file ../../../../../mozilla/content/events/src/nsEventListenerManager.cpp, line 770
--DOMWINDOW == 90 (0x13bd37808) [serial = 565] [outer = 0x0] [url = chrome://messenger/content/msgAccountCentral.xul]
--DOMWINDOW == 89 (0x13e2f5758) [serial = 550] [outer = 0x0] [url = chrome://messenger/content/msgAccountCentral.xul]
--DOMWINDOW == 88 (0x13b1617c8) [serial = 544] [outer = 0x0] [url = chrome://messenger/content/msgAccountCentral.xul]
--DOMWINDOW == 87 (0x13f7d1ff8) [serial = 464] [outer = 0x0] [url = chrome://messenger/content/msgAccountCentral.xul]
--DOMWINDOW == 86 (0x13c352698) [serial = 601] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 85 (0x116e27588) [serial = 284] [outer = 0x0] [url = about:blank]
--DOMWINDOW == 84 (0x13efa35a8) [serial = 531] [outer = 0x115acf008] [url = mailbox:///builds/slave/talos-slave/test/build/mozmill/mozmillprofile/Mail/Local%20Folders/FolderPaneVisibility?number=0]
--DOMWINDOW == 83 (0x128350e98) [serial = 633] [outer = 0x13e6dce38] [url = about:blank]
++DOMWINDOW == 84 (0x10e2e27e8) [serial = 637] [outer = 0x13ba893d8]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/mozmill/folder-display/test-message-commands.js | test-message-commands.js::test_tag_keys_disabled_in_content_tab
Keywords: intermittent-failure
It can also be seen on Linux debug right now, https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=73e4c1eca85a

05:45:39     INFO -  SUMMARY-UNEXPECTED-FAIL | test-message-commands.js | test-message-commands.js::test_tag_keys_disabled_in_content_tab
05:45:39     INFO -    EXCEPTION: Timeout waiting for the content tab page to load.
05:45:39     INFO -      at: utils.js line 447
05:45:39     INFO -         TimeoutError utils.js:447 13
05:45:39     INFO -         waitFor utils.js:485 1
05:45:39     INFO -         wait_for_content_tab_load test-content-tab-helpers.js:253 1
05:45:39     INFO -         test_tag_keys_disabled_in_content_tab test-message-commands.js:531 3
05:45:39     INFO -         Runner.prototype.wrapper frame.js:585 9
05:45:39     INFO -         Runner.prototype._runTestModule frame.js:655 9
05:45:39     INFO -         Runner.prototype.runTestModule frame.js:701 3
05:45:39     INFO -         Runner.prototype.runTestDirectory frame.js:525 7
05:45:39     INFO -         runTestDirectory frame.js:707 3
05:45:39     INFO -         Bridge.prototype._execFunction server.js:179 10
05:45:39     INFO -         Bridge.prototype.execFunction server.js:183 16
05:45:39     INFO -         Session.prototype.receive server.js:283 3
05:45:39     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3
Attached patch patch — — Splinter Review 
The particular test opens the addon manager tab, which takes some seconds even locally. It may be that we hit the default 5s timeout when running the slower debug build on the servers. This patch increases the timeout to 15s. The failure is currently not seen on try server (but I still pushed there), only on trunk. So we had to push there to see.
Attachment #8693335 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8693335 [details] [diff] [review]
patch

Review of attachment 8693335 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't hurt to try it. r=mkmelin
Attachment #8693335 - Flags: review?(mkmelin+mozilla) → review+
https://hg.mozilla.org/comm-central/rev/f10a646bee23

Aceman, please add a commit comment (the bzpost extension will do this for you automatically) and close the bugs when you land things.

Leaving this bug open as the failure still happens.
(In reply to :aceman from comment #27)
> The particular test opens the addon manager tab, which takes some seconds
> even locally. It may be that we hit the default 5s timeout when running the
> slower debug build on the servers. This patch increases the timeout to 15s.
> The failure is currently not seen on try server (but I still pushed there),
> only on trunk. So we had to push there to see.

Considering this is intermittent, did this patch help? If so, maybe even 15s are not enough?
I'm not sure what to do next. The failures repeat on Linux debug, but I can't reproduce them there.

No failures for 6 years.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: