910300 - JS Strict warning "reference to undefined property options.bytes"

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[:Irving Reid (No longer working on Firefox)]

Seeing "reference to undefined property options.bytes" warnings in my log. Oddly, the warnings don't come with any file/line number information, and are not terminated with a linefeed. For example:

*** LOG DeferredSave/extensions.json: Starting write
reference to undefined property options.bytes*** LOG DeferredSave/extensions.json: Write succeeded
*** LOG addons.xpi-utils: XPI Database saved, setting schema version preference to 15


DXR shows the only reads of options.bytes to be in osfile_shared_front.jsm: http://dxr.mozilla.org/mozilla-central/search?tree=mozilla-central&q=options.bytes&redirect=true

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

I'm seeing lots of these lately. They look like this:
  JavaScript Warning: "reference to undefined property options.bytes" {file: "resource://gre/modules/osfile/osfile_shared_front.jsm" line: 116}

Comment 2

[Cameron McCormack (:heycam)]

Attachment: patch

Sorry for stealing a mentorable bug, but this is annoying me too much!

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 805778 [details] [diff] [review]
patch

Review of attachment 805778 [details] [diff] [review]:
-----------------------------------------------------------------

Is that sufficient to make the warning disappear?
/me will never understand how JS warnings work.

Comment 4

[Cameron McCormack (:heycam)]

I'm not sure why that makes it OK, despite still accessing the non-existent property, but there is at least one other example of JS code that does this to silence a warning, and testing locally confirmed it worked.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 805778 [details] [diff] [review]
patch

Review of attachment 805778 [details] [diff] [review]:
-----------------------------------------------------------------

Well, in that case, r=me.

Comment 6

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5c382723ba56

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5c382723ba56