910339 - [e.me] Un-ignore jslint

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

There's much whitespace to be removed, tabs to be replaced with spaces and lines to be broken. Better have it in one PR.

Comment 2

[Amir Nissim (:amirn)]

Attachment: redirect to PR 12854.html

add ?w=1 to the url to hide whitespace diff

Comment 3

[Amir Nissim (:amirn)]

This is a big task.

The PR contains only cosmetic changes that I was sure (read hope) will not break the code.

There is, however, more "dangerous" linting needed (e.g. breaking lines that are too long) that might break the code.

Since this ticket turned out huge already, I suggest it will include only "safe" linting changes.
Further linting can be carried out *cautiously* one file at a time, to make sure nothing breaks.

What do you think?

Comment 4

[Evyatar 'Tron' Amitay (everything.me)]

Hmm... I think it's good to separate, but if we do - we need to put e.me back on the linting ignore list. otherwise we won't be able to commit because of the long lines.
allowing linting should be added back once we're done all linting tasks IMO.

Comment 5

[Amir Nissim (:amirn)]

The linting scheme was changed recently and *will not* force you to break long lines when committing your changes.
(see https://github.com/mozilla-b2g/gaia/commit/ccfcf9fca37accaab029e78747ebf5ccb3fb19d1)

What I did in this PR is to fix all issues that *would* prevent you from committing (double quotes, EOF line breaks etc.)

Comment 6

[Amir Nissim (:amirn)]

Please ignore my previous comment - Evyatar is correct.

I was running `APP=homescreen make hint` which runs jshint and does not warn about long lines (but warns about other stuff) but the pre-commit hook runs `make lint` which *does* raise 'line too long' errors.

I will update the PR once I fix remaining jslint issues.

Thanks.

Comment 7

[Amir Nissim (:amirn)]

OK guys, updated the PR. Please review. 10x.

Comment 8

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 817118 [details]
redirect to PR 12854.html

Pretty hard reviewing all the code, obviously, but I flicked through it and it looks good. Built to the device and didn't find any issues.

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 817118 [details]
redirect to PR 12854.html

I went over everything. EVERYTHING!
There were some comma mistakes that wowed me.

Anywho, it's all good and no functional breakage.

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 817118 [details]
redirect to PR 12854.html

I cannot add more :)

Comment 11

[Amir Nissim (:amirn)]

landed in master
thanks.

https://github.com/mozilla-b2g/gaia/commit/69575e3b40931c1cf2060e812db4b20f81040de5

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

Btw, Cristian we found what's causing our spacing problem. It had to do with a git setting that messed spacing on every cherry-pick...