910351 - [e.me][feature] Apply full bg image new design

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Additional information:
Currently full bgimage mode (swipe results down till they disappear) displays a footer with info.

1. Attached is the new design.
2. Clicking the "wallpaper" pops up an alert for saving the image as wallpaper.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Full screen redesign

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

Link to commit:
https://github.com/EverythingMe/gaia/commit/ee1bde39432b42bdac62af691e81a23f11aec89b

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 5

[Cristian Rodriguez (:crdlc)]

r+ for the attachment ;)

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

Addressed comments on GH and Travis passed.
Cristian, are we good to land (no r+ yet)?

Comment 7

[Cristian Rodriguez (:crdlc)]

It is not r+ because I am not agree with the markup

See https://github.com/mozilla-b2g/gaia/pull/12475#issuecomment-25172408

Comment 8

[Cristian Rodriguez (:crdlc)]

I don't want to see a separator as image, please review with detail the header bb

Comment 9

[Evyatar 'Tron' Amitay (everything.me)]

as far as I can tell the BB also uses an image... am I looking at the wrong place?
https://github.com/mozilla-b2g/gaia/blob/master/shared/style/headers.css#L239

Comment 10

[Cristian Rodriguez (:crdlc)]

Sorry, I didn't see you comment, so r+

Comment 11

[Evyatar 'Tron' Amitay (everything.me)]

great! thanks, merged into master
ced4f2a44e81a61405d45f5a8298f4d5d1870162

https://github.com/mozilla-b2g/gaia/commit/ced4f2a44e81a61405d45f5a8298f4d5d1870162

Comment 12

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version