Open Bug 910388 Opened 11 years ago Updated 2 years ago

Improve documentation and API around PLDHashMoveEntry

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

People

(Reporter: justin.lebar+bug, Unassigned)

Details

PLDHashMoveEntry's documentation is currently pretty cryptic.  For example, most consumers will need to call |from|'s destructor, but that isn't mentioned anywhere.

Moreover, the API is wrong, afaict: |from| is a |const EntryType*|, but you're welcome to modify it!

The documentation should describe using a C++11 move constructor (together with placement-new) and calling |from|'s destructor, unless you know that the data is a POD, in which case you can use memcpy.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.