910389 - B2G xpcshell always exits with "ERROR - Return code: 256" regardless of success of failure

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

This causes the TBPL log parser to parse this as an error.

https://tbpl.mozilla.org/php/getParsedLog.php?id=27124931&tree=Mozilla-Central

b2g_emulator_vm mozilla-central opt test xpcshell on 2013-08-28 10:14:49 PDT for push 85c8745ac6c4
slave: tst-linux64-ec2-080

10:20:28     INFO -  INFO | Result summary:
10:20:28     INFO -  INFO | Passed: 40
10:20:28     INFO -  INFO | Failed: 0
10:20:28     INFO -  INFO | Todo: 0
10:20:28    ERROR - Return code: 256
10:20:28     INFO - TinderboxPrint: xpcshell<br/>40/0
10:20:28     INFO - # TBPL SUCCESS #
10:20:28     INFO - The xpcshell suite: xpcshell ran with return status: SUCCESS

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I blame the intern.

Comment 2

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: Fix B2G runxpcshelltests return code

Changed to the same pattern we use for Android[1].

[1] http://mxr.mozilla.org/mozilla-central/source/testing/xpcshell/remotexpcshelltests.py#543

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

As Andrew pointed out, the problem is that we are doing int(True) which gives != 0.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/05940765167e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/05940765167e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2fb19341d934

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/2fb19341d934