910415 - SkiaGL crashes while using dead GLContext

Status: RESOLVED INVALID

(Core :: Graphics: Canvas2D, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

I'm getting a segfault in GLContextSkia::EnsureGLContext when I visit http://ie.microsoft.com/testdrive/Performance/FishBowl/Default.html

It looks like SurfaceStreamHostOGL unrefs it more times than we expect.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Ensure the SurfaceStreamHostOGL is reused, avoiding double unref

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67b98c1c0b7b

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out for likely causing OSX leaks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc942eb6a075

https://tbpl.mozilla.org/php/getParsedLog.php?id=27184616&tree=Mozilla-Inbound

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Confirmed that the backout fixed the leaks.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:lsalzman, could you have a look please?
For more information, please visit auto_nag documentation.