Closed Bug 910429 Opened 12 years ago Closed 12 years ago

Add KHR_debug support to GLContext

Categories

(Core :: Graphics: CanvasWebGL, defect)

Product:
Core
Component:
Graphics: CanvasWebGL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(
URL
)

Details

Attachments

(1 file, 3 obsolete files)

khr-debug
13.54 KB, patch
bjacob
: review+
Details | Diff | Splinter Review
This could be really useful for debugging and profiling.
Attached patch khr-debug (obsolete) — — Splinter Review
Attachment #796863 - Flags: review?(bjacob)
Attached patch khr-debug (obsolete) — — Splinter Review
Oops, forgot to add the KHR suffix symbol strings for GLES.
Attachment #796863 - Attachment is obsolete: true
Attachment #796863 - Flags: review?(bjacob)
Attachment #796865 - Flags: review?(bjacob)
Attachment #796865 - Flags: review?(bjacob) → review+
Attached patch khr-debug (obsolete) — — Splinter Review
I missed that one of these returns GLuint, so I fixed it.
Attachment #796865 - Attachment is obsolete: true
Attachment #796903 - Flags: review+
Keywords: checkin-needed
Attached patch khr-debug — — Splinter Review
Looks like we needed to add an include to get `APIENTRY` on windows: https://tbpl.mozilla.org/?tree=Try&rev=ed108df99a20
Attachment #796903 - Attachment is obsolete: true
Attachment #805647 - Flags: review?(bjacob)
Attachment #805647 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/18cb711670f6
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: