910531 - [Buri][Settings] Data still be available even the user choose "Not Now"

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[sync-1]

Firefox os  v1.1
 Mozilla build ID:20130817041203
 
 DEFECT DESCRIPTION:
 When turn on the data connection for the first time, there will be a warning message pop up to warn the user data usage:
 1 when user choose "not now" 
 2 data connection show turn off and there is no icon of mobile data in the statusbar. It is OK.
 3 but the mobile data is available in reality------launch the browser, we can surf the internet------NOT OK!!!
 
  REPRODUCING PROCEDURES:
 as the description.
 
  EXPECTED BEHAVIOUR:
 when the user choose "not now", the mobile data should be disabled.
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
 1/1
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[xiaokang.chen]

Dear Arthur,
Could you have a look at this? Thank you!

Comment 2

[xiaokang.chen]

Dear Arthur,
handleEvent in Settings.js set 'ril.data.enabled' to 'true' when we click the data connection swich. Immediately following, initWarnings in Carrier.js set 'ril.data.enabled' to 'false' before the openDialog. But the false didn't take effect though the value changed in settings indexedDB.

Is that a bug of the Settings API? Maybe we should fix this in gecko.

By the way, if we set 'ril.data.enabled' in onReset when user clicks 'not now'. But if the user press homekey in the pop up message page. Mobile data will be always on without user's conciousness.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

I cannot reproduce it using the build (https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/2013/08/2013-08-22-04-12-01/).

Could you help check if the wifi is available while you do the tests? And in onReset we don't set `ril.data.enabled`. We simply set a flag of the warning dialog.

Comment 4

[xiaokang.chen]

I do the test right after flashed the phone, so the wifi is not available cause I never connected an WI-FI AP after I flash the phone.

Comment 5

[Preeti Raghunath(:Preeti)]

QA,

Please check if the issue is reproducible.

Comment 6

[Deepa Subramanian]

I was able to reproduce this issue on Leo and Buri using v 1.1 Commercial RIL. When the user taps on "NOT NOW" button on settings data connection, the user is able to browse the internet. 

Buri Build ID: 20130829041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/0c3c48cc121d
Gaia: 23eadfd88057dc524f4452e48813503627f77fbe
Platform Version: 18.1
COM RIL Version: 01.01.00.019.206

Comment 7

[Jason Smith [:jsmith]]

QAWanted - Can we check to see if we can reproduce this on a Buri 1.1 partner build? We're trying to understand if it's partner-specific issue or not.

Comment 8

[Deepa Subramanian]

This issue reproduces on the Buri partner build for v 1.1. The user is able to go online when the cellular data is not selected. 

Repro rate 9/10.

Environmental variables:
Buri Build ID: 20130822172034
Gecko: /rev/
Gaia: 743bc0fd1c239632a65f337a7a1e2c9d17ff8190
Platform Version: 18.1

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

ni? Anshul / mvines as this seems to be happening on commercial RIL only. Thanks

Comment 10

[Michael Vines [:m1] [:evilmachines]]

Thanks Joe.

Reporter, please create an SR so we can support.  Also if you share the SR # here we can ensure a smooth handoff.  Thanks!

Comment 11

[xiaokang.chen]

Dear All,
I have filed an SR:01288865.

Comment 12

[xiaokang.chen]

Dear All,
I found a new bug like this:
1 Settings>cellular and data>click the data connection button quickly and repeatedly for many times 
2 sometimes we will find that the UI shows data connection is disabled but we can surf the internet which means the data connection is enabled indeed. (reproduce rate is 1/2)

IMHO, why don't we add protection maybe a delay like 1/2 seconds for the "data connection" button in gaia to avoid this bug.

And for the "not now" bug, why don't we just ignor the first set for "ril.data.enabled" in settings.js. But not set true in settings.js then set false before open the alert message dialog in the carrier.js. It's a little bit complicated and easy to arouse problems in low level code.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

For the problem of repeatedly switching the toggles, I suspect it may be resulted from setting to mozSettings failure. I'll check the root cause.

You've raised a good point on the "not now" button! Maybe we can add a event listener to the onclick event and prevent the default action in it, so that we have a chance to prevent setting the value to mozSettings immediately.

Comment 14

[pgravel]

I was about to make the same point. Data should never get enabled, however briefly, until the user confirms that data should be enabled.

SR is being addressed, fix will be delivered soon.

Comment 15

[xiaokang.chen]

Dear All,
Qualcomm has fixed the "not now" problem.
But the problem:
1 Settings>cellular and data>click the data connection button quickly and repeatedly for many times 
2 sometimes we will find that the UI shows data connection is disabled but we can surf the internet which means the data connection is enabled indeed. (reproduce rate is 1/2)
Still exist.
IMHO, we should add some protection in gaia/gecko ASAP cause this is a serious problem.