910553 - create plugin to inject content before page loads (for shims)

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Comment 1

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

Pointer to Github pull-request

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 797087 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

This is somewhat of a quick hack but it does what you need it to.. In addition I wanted to add a new api something like:

marionette.contentScripts.expose('navigator.mozAlarms', '/path/from/test/to/shim.js');

This needs more docs and probably more tests... I may have found a bug where marionette.apps.launch can only be called once until the app is closed as well and I will track that down.

Comment 3

[Evan Tseng [:evanxd]]

Hi James,

I already publish marionette-content-script as a alpha version in NPM.
You're also a maintainer of it in NPM.

And nice work!

Comment 4

[Evan Tseng [:evanxd]]

Hi James,

The patch looks good and fantastic.
Help me a lot.

Just some nits in GitHub.

Comment 5

[James Lal [:lightsofapollo]]

https://github.com/mozilla-b2g/marionette-content-script/commit/0bd1b2334d4d312707fb6330040433ec66096f9c

Addressed review comments and landed.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 797087 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

Nice work.