If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

create plugin to inject content before page loads (for shims)

RESOLVED FIXED

Status

Testing
JSMarionette
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: lightsofapollo, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

4 years ago
Created attachment 797087 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

Pointer to Github pull-request
(Reporter)

Comment 2

4 years ago
Comment on attachment 797087 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

This is somewhat of a quick hack but it does what you need it to.. In addition I wanted to add a new api something like:

marionette.contentScripts.expose('navigator.mozAlarms', '/path/from/test/to/shim.js');

This needs more docs and probably more tests... I may have found a bug where marionette.apps.launch can only be called once until the app is closed as well and I will track that down.
Attachment #797087 - Flags: review?(evanxd)
(Reporter)

Updated

4 years ago
Blocks: 910455

Comment 3

4 years ago
Hi James,

I already publish marionette-content-script as a alpha version in NPM.
You're also a maintainer of it in NPM.

And nice work!

Comment 4

4 years ago
Hi James,

The patch looks good and fantastic.
Help me a lot.

Just some nits in GitHub.
(Reporter)

Comment 5

4 years ago
https://github.com/mozilla-b2g/marionette-content-script/commit/0bd1b2334d4d312707fb6330040433ec66096f9c

Addressed review comments and landed.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 6

4 years ago
Comment on attachment 797087 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/marionette-content-script/pull/1

Nice work.
Attachment #797087 - Flags: review?(evanxd) → review+
You need to log in before you can comment on or make changes to this bug.