Closed
Bug 910595
Opened 11 years ago
Closed 11 years ago
Make sure the Side Menu Widget "item" does not affect the positioning of the child "item-contents"
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
9.78 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
The current structure of an item in this widget is like this: <hbox class="item> <hbox class="item-checkbox"> <vbox class="item-contents"> <hbox class="item-arrow"> </hbox> The "item-contents" (a.k.a the "target" in widget terminology) will contain the display of actual data, for example a label in the debugger's case. However, the "item" (a.k.a "target container") defines some padding, so the dimensions of the item itself are not entirely defined by the contents. This seemed a good idea back in the day, but doesn't work well if you want to reliably listen for mouseenter and mouseleave on the widget with bubbling enabled. tl;dr: let's leave the layout dimensions to be completely defined by the contents.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 797103 [details] [diff] [review] widgets-css.patch LGTM
Attachment #797103 -
Flags: review?(nfitzgerald) → review+
Assignee | ||
Updated•11 years ago
|
Whiteboard: [land-in-fx-team]
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7f72c69e437b
Whiteboard: [land-in-fx-team]
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7f72c69e437b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•