910686 - If udp.wakeupEnabled is "false" or not set, we should not send any wakeup info

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Guillermo López :willyaranda (probably SLOW response)]

STR:

1) Change "services.push.udp.wakeupEnabled" to "false".
2) Register on 3G, device sends everything for wakeup
3) Server disconnects with 7447 for UDP
4) Device tries to start the socket to listen for wakeup: it cannot since udp.wakeupEnabled is "false".
5) Someone sends a notification
6) Device is unreachable. It has not a WebSocket nor is ready to be woken up

Actual results:
Connection is closed with wakeup code but device is not listening for wake up.

Expected:
Connection is not closed (device does not send any info about UDP wakeup), and we kept the WS open, living happily.

Comment 1

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: Patch for m-c

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 797197 [details] [diff] [review]
Patch for m-c

Review of attachment 797197 [details] [diff] [review]:
-----------------------------------------------------------------

This will work, but move the check into the try block, and have it throw if the pref is false.
Then move the return value into the catch block. This way we'll reduce duplication.

Comment 3

[Guillermo López :willyaranda (probably SLOW response)]

Attachment: 0001-Bug-910686-If-udp.wakeupEnabled-is-false-or-not-set-.patch

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/172f3ed29721

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/172f3ed29721