Closed Bug 910686 Opened 8 years ago Closed 8 years ago

If udp.wakeupEnabled is "false" or not set, we should not send any wakeup info

Categories

(Core :: DOM: Push Notifications, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: willyaranda, Assigned: willyaranda)

Details

Attachments

(1 file, 1 obsolete file)

STR:

1) Change "services.push.udp.wakeupEnabled" to "false".
2) Register on 3G, device sends everything for wakeup
3) Server disconnects with 7447 for UDP
4) Device tries to start the socket to listen for wakeup: it cannot since udp.wakeupEnabled is "false".
5) Someone sends a notification
6) Device is unreachable. It has not a WebSocket nor is ready to be woken up

Actual results:
Connection is closed with wakeup code but device is not listening for wake up.

Expected:
Connection is not closed (device does not send any info about UDP wakeup), and we kept the WS open, living happily.
Attached patch Patch for m-c (obsolete) — Splinter Review
Attachment #797197 - Flags: review?(nsm.nikhil)
Comment on attachment 797197 [details] [diff] [review]
Patch for m-c

Review of attachment 797197 [details] [diff] [review]:
-----------------------------------------------------------------

This will work, but move the check into the try block, and have it throw if the pref is false.
Then move the return value into the catch block. This way we'll reduce duplication.
Attachment #797197 - Flags: review?(nsm.nikhil) → review-
Assignee: nobody → willyaranda
Attachment #797197 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #797303 - Flags: review?(nsm.nikhil)
https://hg.mozilla.org/mozilla-central/rev/172f3ed29721
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.