910727 - patcher-config-bump.pl shouldn't fail if there are no partials in the patcher config

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

Thunderbird 24.0b2 updates failed with the following:

Use of uninitialized value $oldPartialVersions[0] in hash element at tools/release/patcher-config-bump.pl line 258.
Use of uninitialized value $newPath in substitution (s///) at tools/lib/perl/Release/Patcher/Config.pm line 138.
Use of uninitialized value $newPath in pattern match (m//) at tools/lib/perl/Release/Patcher/Config.pm line 140.
Use of uninitialized value $newPath in pattern match (m//) at tools/lib/perl/Release/Patcher/Config.pm line 145.
Use of uninitialized value $oldFilePath in concatenation (.) or string at tools/lib/perl/Release/Patcher/Config.pm line 151.
ASSERT: BumpFilePath() - Unknown file type for '' at tools/lib/perl/Release/Patcher/Config.pm line 151.

The patcher config file contains the following:

<partials>
</partials>

what makes the code unhappy - it cannot find "betatest-url" and "path" in that block and cannot bump.

Using default values for would be better.

Patch incoming.

Comment 1

[Rail Aliiev [:rail]]

Attachment: fall back to default values

It generates the following bump: https://gist.github.com/rail/6379312
It looks sane to me.

Comment 2

[Rail Aliiev [:rail]]

Attachment: fall back to default values

Since BumpFilePath strips everything up to build\d+\/ (http://mxr.mozilla.org/build/source/tools/lib/perl/Release/Patcher/Config.pm#138) there is no reason to populate it. The bumper patch is exactly the same.

Comment 3

[John Hopkins (:jhopkins)]

Comment on attachment 797282 [details] [diff] [review]
fall back to default values

Please add a semicolon after:

 $oldPaths->{"betatest-url"} = $oldPaths->{"path"}

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 797282 [details] [diff] [review]
fall back to default values

https://hg.mozilla.org/build/tools/rev/28bf6229b6d2

Comment 5

[Rail Aliiev [:rail]]

(In reply to John Hopkins (:jhopkins) from comment #3)
> Comment on attachment 797282 [details] [diff] [review]
> fall back to default values
> 
> Please add a semicolon after:
> 
>  $oldPaths->{"betatest-url"} = $oldPaths->{"path"}

I blame Python! :)