Closed Bug 910877 Opened 6 years ago Closed 6 years ago

Fix autoconf detection of math library functions

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: sunfish, Assigned: sunfish)

Details

Attachments

(1 file)

As mentioned in bug 717379, the current autoconf checks for math library routines are failing to detect them in common cases. Attached is the patch to fix it, in a new bug.
Attachment #797461 - Flags: review?(david.caabeiro)
Thank you for the patch Dan, it's much appreciated. May I ask you to flag this for review to jorendorff@mozilla.com instead? He's actually the one in charge of reviewing for this bug. Thanks!
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch

Ok, changing the review to :jorendorff.
Attachment #797461 - Flags: review?(david.caabeiro) → review?(jorendorff)
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch

Bouncing to ted, who understands this stuff.
Attachment #797461 - Flags: review?(jorendorff) → review?(ted)
Comment on attachment 797461 [details] [diff] [review]
math-lib-detect.patch

Review of attachment 797461 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I always have to refresh my memory when reviewing autoconf patches. This looks fine.
Attachment #797461 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/0f253a183a93
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.