Mac GL code gets preferences off the main thread

RESOLVED FIXED in mozilla28

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

See https://tbpl.mozilla.org/php/getParsedLog.php?id=27190623&full=1&branch=try#error0

We're creating GL stuff on the ipc thread (seems weird) which tries to get preferences.
GLContext constructor queries gl.blit-draw-not-copy preference.
Milan, can you or someone on your team take this?
Flags: needinfo?(milan)
I wanted to finish bug 910881 to make sure it is "done correctly" before jumping into the second one.
Assignee: nobody → milan
Flags: needinfo?(milan)
Ping?
Flags: needinfo?(milan)

Comment 5

4 years ago
We can delete that pref. Kyle can you do a quick patch?
Created attachment 8342843 [details] [diff] [review]
Patch

Are you volunteering to review? ;-)
Attachment #8342843 - Flags: review?(gal)

Comment 7

4 years ago
Comment on attachment 8342843 [details] [diff] [review]
Patch

Review of attachment 8342843 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)
Attachment #8342843 - Flags: review?(gal) → review+

Updated

4 years ago
Keywords: checkin-needed
Flags: needinfo?(milan)
Assignee: milan → khuey
https://hg.mozilla.org/mozilla-central/rev/b3b9e8733a5d
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.