Closed Bug 910878 Opened 7 years ago Closed 6 years ago

Mac GL code gets preferences off the main thread

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: khuey, Assigned: khuey)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

See https://tbpl.mozilla.org/php/getParsedLog.php?id=27190623&full=1&branch=try#error0

We're creating GL stuff on the ipc thread (seems weird) which tries to get preferences.
GLContext constructor queries gl.blit-draw-not-copy preference.
Milan, can you or someone on your team take this?
Flags: needinfo?(milan)
I wanted to finish bug 910881 to make sure it is "done correctly" before jumping into the second one.
Assignee: nobody → milan
Flags: needinfo?(milan)
Ping?
Flags: needinfo?(milan)
We can delete that pref. Kyle can you do a quick patch?
Attached patch PatchSplinter Review
Are you volunteering to review? ;-)
Attachment #8342843 - Flags: review?(gal)
Comment on attachment 8342843 [details] [diff] [review]
Patch

Review of attachment 8342843 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :)
Attachment #8342843 - Flags: review?(gal) → review+
Keywords: checkin-needed
Flags: needinfo?(milan)
Assignee: milan → khuey
https://hg.mozilla.org/mozilla-central/rev/b3b9e8733a5d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.