911026 - B2G SMS: regression in bug 899885 made SMS-DELIVER-REPORT unavailable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Enpei]

Attachment: time stamp: 13:39, 8/30

There is no tick icon next to sent message even delivery report is on. Due to no UI indicator, I cannot tell whether no delivery report is received or it's SMS UI issue.

* Build Number                
Gaia mozillaorg/master - 09cfa8afaf88b49fc58ee33ec29071038b7cea2c
Gecko mozillaorg/master - 6e7aba3837664574da9fafb9f4ff017276e500ba
BuildID   20130829061633
Version   26.0a1

* Reproduce Steps
1. Enable delivery report 
2. Send a sms to other device.

* Expected Result
Tick icon will be seen on DUT in the message just sent after it's received by MT side.

* Actual Result
No tick icon.

* Occurrence rate
100%

Comment 1

[Julien Wajsberg [:julienw]]

Steve probably knows.

Comment 2

[Steve Chung [:steveck]]

I don't have the target device wasabi right now, but I found another problem on unagi while updating the message database:

[JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMobileMessageService.createSmsMessage]" {file: "jar:file:///system/b2g/omni.ja!/components/MobileMessageDatabaseService.js" line: 818}]

This error occurs while database updating the message deliveryStatus to delivery success. It will cause the message unable to save into database and no event dispatched to gaia for sure. For you refresh the message lit again, the messsage should be updated to delivery success will disappear in current build. Need gecko devs help for further investigation.

Comment 3

[Gene Lian (I already quit Mozilla)]

Sadly, I'm going to have PTOs and not be available until 9/5. Could Ctai help with this? Thanks!

Comment 4

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-911026.patch

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cf7872e7087b

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cf7872e7087b

Comment 7

[Enpei]

Hi all,

I can still reproduce the issue with today's build, could you check if it's landed already?
Wasabi:
Gaia:     37bcf182902ce19aba99d8f381cfecdd161d6d8a
Gecko:   99509409adbd6c3063f6de5462a6a2797f2e4c47
BuildID   20130904062051
Version   26.0a1

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

(In reply to echu from comment #7)
> Hi all,
> 
> I can still reproduce the issue with today's build, could you check if it's
> landed already?

Yes, it's already included in that Gecko commit and this does work for me.

Comment 9

[Gene Lian (I already quit Mozilla)]

Thanks Ctai and Vicamo!

Btw, I just found there is another tiny spot at:

  if (response.errorMsg) {
    ...
    switch (message.errorMsg) { --> wrong!
      ...
    }
    ...
  }

which is a similar issue. Could we reopen this bug to fix that or just fire a separate bug? Either works for me. Thanks!

Comment 10

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

There is already a bug about what you are talking about.
Please see Bug 911690.

(In reply to Gene Lian [:gene] (please use needinfo?) from comment #9)
> Thanks Ctai and Vicamo!
> 
> Btw, I just found there is another tiny spot at:
> 
>   if (response.errorMsg) {
>     ...
>     switch (message.errorMsg) { --> wrong!
>       ...
>     }
>     ...
>   }
> 
> which is a similar issue. Could we reopen this bug to fix that or just fire
> a separate bug? Either works for me. Thanks!

Comment 11

[Enpei]

Hi Vicamo,

I still can't get delivery icon on today's build, can you check the log?
Gaia:     f2ca2f21e75b7e1db4183960f69810422295c21f
Gecko:   2a2ff267b86346ae80e453a814c442da82583ab1
BuildID   20130905062051
Version   26.0a1

Comment 12

[Enpei]

Attachment: 10:45, 9/6.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

In attachment 800547 [details] it has:

  RIL Worker[0]: Handling parcel as REQUEST_CDMA_SEND_SMS

The solution we had is for GSM phones.  CDMA SMS has no DELIVER-REPORT support yet.

Comment 14

[Enpei]

Set status to Reopened.

Comment 15

[Gene Lian (I already quit Mozilla)]

Why reopening this? This one has been solved.

Comment 16

[Enpei]

The build I filed the bug with is wasabi which is CDMA, it's still no fixed yet.

Comment 17

[Vicamo Yang [:vicamo][:vyang]]

(In reply to Enpei from comment #16)
> The build I filed the bug with is wasabi which is CDMA, it's still no fixed
> yet.

Please track bug 913313 instead.  We didn't noticed this is for CDMA, and we had same problem for GSM and had been fixed in this bug.

Comment 18

[Enpei]

Sorry, I mixed up this with bug 913313, I will track it there.