911028 - [B2G][Helix][messages][zhaotao]In some cases,phone number matches to wrong contact

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba; Zune 4.7)

Steps to reproduce:

【Detail Description*】：In some cases,phone number matches to wrong contact
【Repro Steps*】：
1、First store two contact: test1 with phone number 123123123,test2 with phone number 123123123123
2、open messages app,and send a sms to [phone]



Actual results:

【Real Result*】：send sms to [phone],the phone number matched to test2

【Test Count*】：5
【Found Count*】：5
【Gaia commit ID*】:c0ea0a4943dc8d3751b07f5b5c5d3abe06364a14 
【Gecko commit ID*】:170f9e477571127cd40997fa2abe262ed43f0e4d
【Log*】：NA
【Network environment】：NA
【Resume operation】：NA
【Carrier】：NA


Expected results:

【Expect Result*】：the phone number [phone] should match to test1

Comment 1

[Julien Wajsberg [:julienw]]

Are these phones numbers all valid phone numbers ?

Comment 2

[lecky]

hi,julien

We use these phone numbers for test purpose.

Comment 3

[Julien Wajsberg [:julienw]]

But do they look like real phone numbers, I mean, in the format ?

Comment 4

[Caio Lima(:caiolima)]

Actually, talking from my experience with phone numbers here in Brazil, we are use to have numbers in this format

(xx) yyyy yyyy where: 

xx - is the local area(I mean, the city area)
yyyy yyyy - is the phone number itself;

We can either send messages using only "yyyy yyyy" where, by default of xx, it uses the value of area that we are at the moment of sending.

So, In this case we have some definitions for the same number here in Brazil. Imagine we have the phone number [phone] as a valid number here following the international convention.

The number 7132321144 and 07132321144 and 0417132321144 will send messages to the same number.

So, adding to "+" to 0417132321144 will result in +0417132321144 wich is another number(I don't even know if it's valid). I don't know too much about the contact match or anything like that on gaia, but It's how the things work here in Brazil. I don't know if it's different on other places.

BTW, how does the cantact api work internaly to save contacts that default the area and the country code?

It's a little confusing, but I guess that I can help to validate this bug.

Comment 5

[lecky]

hi,julien

what is the progress of this issue?

i have tested on version:

gaia：8059864bd278645ab5d2598b5ed595154136c253
gecko：0265cd51b4dc64ca100353482ada2025df6f5f53
gonk-misc：ca9192d7ef6037016d4723647d86b72f7a410633

and the problem still exist, 

or will it be fixed on V1.1?

Comment 6

[Julien Wajsberg [:julienw]]

Hi lecky,

I think the behaviour is correct for _real_ numbers in _real_ countries.

I know this is not perfect but the issue with phone number matching is very complex, as it changes depending on the country, and we do things differently depending on the SIM card. I really want to revisit this, but now is just a wrong time as we have other work to do and this seems to work good enough for our purpose.

However, if you see a bug with existing numbers in real countries, then we'll gladly fix it if this is possible.

Comment 7

[lecky]

hi,beatriz

can you accept the issue as julien has said in comment 6?

and the issue will not be solved in V1.1HD.

Comment 8

[Beatriz Rodríguez [:brg]]

(In reply to lecky from comment #7)
> hi,beatriz
> 
> can you accept the issue as julien has said in comment 6?
> 
> and the issue will not be solved in V1.1HD.
Agree with Julien in comment 6.

Comment 9

[Julien Wajsberg [:julienw]]

I tested the STR in comment 0 and it worked properly for me.