911043 - Move the "inject JS:: names into js::" block into its own file, to reduce dependencies on jsapi.h.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

I don't like having the "import JS:: names into js::" hack in jsapi.h, for two
reasons.

- Numerous files within SM include jsapi.h just for this.

- The js:: version of those names are visible outside of SpiderMonkey.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Move the "inject JS:: names into js::" block into its own file, to reduce dependencies on jsapi.h.

This patch moves it into js/src/NamespaceHack.h.  Note that I can't do
IsPoisonedId() in the new file because it's a function defined in jsapi.h.
But it doesn't actually need to be in JS::, so I just moved it to js::.

The patch also fixes a bunch of places in Gecko where we had js::Foo instead of
JS::Foo.  And I had to add some "using namespace JS;" declarations in xpconnect.

This change allows numerous |#include "jsapi.h"| statements to be removed, but
I'll do them in the next patch.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Remove unnecessary jsapi.h includes in SpiderMonkey.

The majority of these were enabled by the creation of NamespaceHack.h.

Comment 3

[Luke Wagner [:luke]]

Comment on attachment 797698 [details] [diff] [review]
(part 1) - Move the "inject JS:: names into js::" block into its own file, to reduce dependencies on jsapi.h.

NamespaceHack.h sounds a bit to self-deprecating for what it is doing; it's a pretty reasonable thing to do.  How about NamespaceImports.h?

Comment 4

[Nicholas Nethercote [inactive]]

> NamespaceHack.h sounds a bit to self-deprecating for what it is doing; it's
> a pretty reasonable thing to do.  How about NamespaceImports.h?

Sounds good, particularly because I won't have to reorder any of the include statements, which means I won't have a painful rebase for part 2 :)

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e60625da760
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dce2a6b6e3d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3e60625da760
https://hg.mozilla.org/mozilla-central/rev/0dce2a6b6e3d