Move WebAudio's BufferDecoder to its own file so it can be shared with MSE

RESOLVED FIXED in Firefox 25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla26
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox25 fixed, firefox26 fixed)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
MSE uses something almost identical, so sharing this code avoids duplicating a bunch of boilerplate.
(Assignee)

Comment 1

6 years ago
Posted patch v0Splinter Review
Attachment #797718 - Flags: review?(cpearce)
(Assignee)

Updated

6 years ago
Blocks: 881512

Comment 2

6 years ago
Please land this patch on Aurora as well, with a=webaudio.  Thanks!
Component: Video/Audio → Web Audio
Comment on attachment 797718 [details] [diff] [review]
v0

Review of attachment 797718 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/BufferDecoder.h
@@ +29,5 @@
> +
> +  // This has to be called before decoding begins
> +  void BeginDecoding(nsIThread* aDecodeThread);
> +
> +  virtual ReentrantMonitor& GetReentrantMonitor() MOZ_OVERRIDE;

We can remove "virtual" on these methods, in particular since they have MOZ_OVERRIDE to make it clear they're overrides.
Attachment #797718 - Flags: review?(cpearce) → review+
(Assignee)

Comment 4

6 years ago
With "virtual" removed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5b67c93e1a0

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #2)
> Please land this patch on Aurora as well, with a=webaudio.  Thanks!

Will do!
(In reply to Chris Pearce (:cpearce) from comment #3)
> We can remove "virtual" on these methods, in particular since they have
> MOZ_OVERRIDE to make it clear they're overrides.

Nooo, please make them virtual so it's obvious they're virtual!
https://hg.mozilla.org/mozilla-central/rev/d5b67c93e1a0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Updated

6 years ago
Whiteboard: [checkin-needed-aurora]
(Assignee)

Comment 7

6 years ago
Attachment #799854 - Flags: review+
https://hg.mozilla.org/releases/mozilla-aurora/rev/0618521e6e13
status-firefox25: --- → fixed
status-firefox26: --- → fixed
Whiteboard: [checkin-needed-aurora]
Is there anything needed from QA here to verify this is fixed?
Flags: needinfo?(kinetik)
(Assignee)

Comment 10

6 years ago
I don't think so.  There's no logical change, just code moving to a new file.
Flags: needinfo?(kinetik)
Thank you Matthew, [qa-].
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.