911061 - FHR mobile page did not ignore identical indicator {OK} in string

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

In https://fhr-dev.allizom.org/zh-TW/mobile/#configuration, there shows: 

xpcomabi: {OK}
OS: {OK}

<space>{OK} should be removed.

Comment 1

[Francesco Lodolo [:flod]]

I think that's because it's spelled uppercase.

If you click "Configurazione" you won't see {ok} for "xpcomabi" but it's in the string.
https://fhr-dev.allizom.org/it/mobile/

We solved a similar problem for bedrock (bug 903216), I'll check if the same fix can be applied here.

Comment 2

[Francesco Lodolo [:flod]]

I think it's an external library, so not sure where to fix it
https://github.com/mozilla/fhr-jelly/blob/master/vendor/dotlang/translate.py#L16

Control was moved from .endswith (like Bedrock) to a regular expression to check in the whole string.
METADATA_MARKERS = re.compile(r'\s?{(ok|l10n-extra)}\s?')

It should be enough to change it to 
METADATA_MARKERS = re.compile(r'\s?{(ok|l10n-extra)}\s?', re.IGNORECASE)

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fhr-jelly/pull/147#issuecomment-23566462

Pointer to Github pull-request

Comment 4

[Francesco Lodolo [:flod]]

Checked on dev, OS: {OK} is correctly displayed as OS: