911068 - [B2G][Helix][video][music][chenhoulai]Particular video files are displayed in the music list.

Status: RESOLVED INCOMPLETE

(Firefox OS Graveyard :: Gaia::Music, defect, P2)

Description

[lecky]

User Agent: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba)

Steps to reproduce:

【Detail Description*】：Particular video files are displayed in the music list.
【Repro Steps*】：
	1、Push a mp4 video file into the handset.
	2、Look for the video file in the video app.
	3、Look for the video file in the music app. 	
【Expect Result*】：
    2、The video file is in the filelist of video app and it can play normally.
      3、The video file is not in the filelist of music app.
【Real Result*】：
    2、The video file is not in the filelist of video app.
      3、The video file is in the filelist of music app and it can not play normally.
【Test Count*】：5
【Found Count*】：5
【Gaia commit ID*】:c0ea0a4943dc8d3751b07f5b5c5d3abe06364a14
【Gecko commit ID*】: c0ea0a4943dc8d3751b07f5b5c5d3abe06364a14
【Log*】：the particular mp4 file
【Network environment】：
【Resume operation】：
【Carrier】：

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Lecky,

May you provide the video file for further examination??

There is a bug before that ask us to support playing of the mp4 file that only contains audio stream in it, bug 882099. May you also check if this is related to bug 882099??

Comment 2

[Dominic Kuo [:dkuo]]

Bug 882099 checks the supported brands and bug 882683 checks the sound/video tracks to filter out video mp4, so issue should be already fixed.

Comment 3

[lecky]

(In reply to John Hu [:johnhu] from comment #1)
> Lecky,

May you provide the video file for further examination??

There is a
> bug before that ask us to support playing of the mp4 file that only contains
> audio stream in it, bug 882099. May you also check if this is related to bug
> 882099??

hi ,Johu,sorry for do not reply this for a long time. I aleady provider the video file in attachment,this specific file is recording by our firefox phone long time ago,the earliest vision maybe,and if rock the phone when recording,it will be system halted，then made this problematic file,and we push it into cellphone,it came to the music list ,please check it ,thank a lot

Comment 4

[lecky]

Attachment: VID_0006.3gp

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Lecky,

I am testing this bug on Helix with master-c branch. This video file is not mp4 file. It's 3gp. It looks like a broken video file. So, the video app doesn't list it in video app because it can't be played.

I had also tested the case of Music. It listed in Music app. We met it before in my memory. I can't make sure the bug number. I will transfer the need info flag to Dominic.

Comment 6

[Dominic Kuo [:dkuo]]

I can confirm attachment 818900 [details] is a broken video and the size is too small(9.48 KB), we could probably just filter out those tiny video/audio files which we already know they are unplayable. But I believe we still lacking some logic on checking the mp4/3gp files for the corner case like this. I think this shouldn't be a blocker unless the issue files are very easy to produce on our devices.

Comment 7

[Maria]

Hi, already agreed offline with OB that this is not a blocker in v1.1hd.

Br

Comment 8

[lecky]

(In reply to Dominic Kuo [:dkuo] from comment #6)
> I can confirm attachment 818900 [details] is a broken video and the size is
> too small(9.48 KB), we could probably just filter out those tiny video/audio
> files which we already know they are unplayable. But I believe we still
> lacking some logic on checking the mp4/3gp files for the corner case like
> this. I think this shouldn't be a blocker unless the issue files are very
> easy to produce on our devices.

hi, Dominic ,thanks for you help .We agreed with you ,that should not be a blocker,but we still want you help to explain why this was in music list.we need to figure out the resonse why it was like this .We will be grateful if you can give us some advice.By the way ,I think we can privoid  some other infomation of the video like this if you need.thanks....

Comment 9

[Dominic Kuo [:dkuo]]

No problem, and I haven't look on this issue in detail, my queue is kind of full. I guess the reason attachment 818900 [details] can be listed in music app is because, although the file is broken but it contains enough metadata and cheated the music parser successfully, so as I mentioned in comment 6, we still lacking some logic on checking the mp4/3gp files for the corner cases.

I am keeping the needinfo flag here so that I won't forget to re-visit it again.

Comment 10

[Eric Kramer [:Kramer]]

This does occur on Open_C 1.4

1.4 Environmental Variables:
Device: Open_C 1.4
BuildID: 20140430000201
Gaia: 81e97c3ca58be0487292011bc59efa4cebab30be
Gecko: 123485e733d5
Version: 30.0
Firmware Version: P821A10-ENG_20140410

Comment 11

[amitav.anand]

This issue is reproducible on Nexus 4.

OS Version : 2.0.0.0 Pre-release
Hardware : Mako
Platform Version : 32.0a1
Git Commit Info : 2014-05-22 03:00:53
Build Identifier: 20140521185612

The attached 3gp file seems to be corrupt. It does not play in Vlc too. The reason it is getting displayed in Music app is because *.3gp is present in type of format supported for music app. on removing *.3gp from B2G/gecko/toolkit/content/devicestorage.properties for music the above attached file is not displayed in music app. 

Got the below trace from gaia/apps/video/js/metadata.js on launching the video app, saying "console.error("Can't play video", videofile.name, e);". Looks like some thing wrong with the video file.

Comment 12

[amitav.anand]

Hi Dominic, Could you please comment on whether removing *.3gpp from devicestorage.properties for music is correct or not? 
Also the video can't be played using VLC and I got a trace saying "Can't play video".

Comment 13

[Jim Porter (:squib)]

This works for me, and we have unit tests for this. Since there aren't any sample files for us to test with this bug, there's not much we can do here.